Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests break on newest image-webp version (0.2.1) #2403

Open
KyleSiefring opened this issue Jan 14, 2025 · 3 comments
Open

unit tests break on newest image-webp version (0.2.1) #2403

KyleSiefring opened this issue Jan 14, 2025 · 3 comments

Comments

@KyleSiefring
Copy link

KyleSiefring commented Jan 14, 2025

./tests/images/webp/extended_images/anim.webp: The decoded image's hash does not match (expected = baaea4f2, actual = 2d4e14e1).
thread 'check_references' panicked at tests/reference_images.rs:299:9:
./tests/images/webp/extended_images/anim.webp: The decoded image's hash does not match (expected = baaea4f2, actual = 2d4e14e1).
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/panicking.rs:74:14
   2: reference_images::check_references::{{closure}}
             at ./tests/reference_images.rs:299:9
   3: reference_images::process_images
             at ./tests/reference_images.rs:37:13
   4: reference_images::check_references
             at ./tests/reference_images.rs:157:5
   5: reference_images::check_references::{{closure}}
             at ./tests/reference_images.rs:156:22
   6: core::ops::function::FnOnce::call_once
             at /home/kyle/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Downgrading to 0.2.0 fixes this.

@kornelski
Copy link
Contributor

Have you checked how these images look like?

Implementation of some algorithms has changed. If the image isn't using the lossless variant, some tiny differences could happen.

@KyleSiefring
Copy link
Author

Have not checked and don't intend to dig further in this case. This is not a issue for me and I'm reporting out of courtesy.

@fintelia
Copy link
Contributor

@KyleSiefring thanks for reporting! I think this test failure is caused by intentional changes from image-rs/image-webp#123, but we should certainly investigate and get the test passing again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants