Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional sanity checks against external resources #84

Open
benmwebb opened this issue Jun 2, 2022 · 0 comments
Open

Add additional sanity checks against external resources #84

benmwebb opened this issue Jun 2, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@benmwebb
Copy link
Contributor

benmwebb commented Jun 2, 2022

As @brindakv mentioned, python-ihm currently does various sanity checks to ensure the generated mmCIF is self-consistent, e.g. checking the model sequence against that in the struct_ref table. However, we could do additional sanity checks (perhaps as part of the make-mmcif.py script, or another script used as part of the deposition pipeline) that validate external resources. (I would be reluctant to have these done as part of generating every file, since they would make multiple network connections, referenced files might not exist at modeling time, and many issues might be warnings rather than errors or would need manual intervention.) For example we could

  • Query UniProt and check to make sure that the struct_ref sequence matches (complication: may need to check multiple versions of the UniProt sequence since it does change).
  • Ping any DOI referenced in the file to make sure it exists.
  • Download any referenced external archive files and make sure that any files referenced inside those archives exist.
  • Look up any accessions (e.g. SASBDB, EMDB) to make sure that a) they exist, b) they have been released and c) they match the model (e.g. by checking model fit or checking that both model and data reference the same UniProt sequence).
  • Look up any PMIDs and make sure the citation matches.
@benmwebb benmwebb added the enhancement New feature or request label Jun 2, 2022
@benmwebb benmwebb self-assigned this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant