Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example unclear about long headers #37

Open
gloinul opened this issue Nov 19, 2020 · 1 comment
Open

Example unclear about long headers #37

gloinul opened this issue Nov 19, 2020 · 1 comment

Comments

@gloinul
Copy link

gloinul commented Nov 19, 2020

The example states:

When the proxy receives a response from target.example.com:443 that
has 0x31323334 as the Destination Connection ID, the proxy will
forward that packet to the client on DATAGRAM flow ID 2.

And the later:

Upon receiving the response, the client starts sending Short Header
packets with a Destination Connection ID of 0x61626364 directly to
the proxy (not tunnelled), and these are forwarded directly to the
target by the proxy. Similarly, Short Header packets from the target
with a Destination Connection ID of 0x31323334 are forwarded directly
to the client.

So the first paragraph I think it is correct as far as long header packets are received. However, will not short header packets from the target arriving at the proxy be forwarded to the client, even if the second request never happened. Thus, the implied connection to the response in the last sentence of the second paragraph is misleading.

@tfpauly
Copy link
Collaborator

tfpauly commented Nov 19, 2020

Forwarding mode does rely on the second request being accepted, to allow the server to choose whether or not to forward. This doesn't support only forwarding in one direction, which we deemed to not be a useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants