-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Microsoft Windows High contrast mode in iddiff #437
Comments
If this enhancement seems interesting to anyone reading this, most of the people I know who work on IETF tools use iOS computers, so if you'd like someone to investigate further on Windows systems (for example, check out High contrast on Windows 11), please hit me up. I'd be happy to do so ... |
We will need to comeup with better colour scheme. |
@kesara - thank you for taking a look at this. I wasn't sure whether changing the colour scheme would fix this problem, or whether High Contrast on Windows was keying off something else. This is what GitHub looks like, in High Contrast, for instance. Does this look like the colours are being used to show the sharp delimiters (say, around this text box, or is something else happening? (I ask, because UI is FAR from my area of clue!) |
@SpencerDawkins Thanks for offering to help to test on the Windows platform.
|
@kesara - my apologies for an insanely late reply (jet lag plus another run through COVID-19 after arriving back in DFW was not helpful). I took a quick look at the links you provided, and I can't see the difference (nor can I see additions and deletions using either version of the diff tool). This is iddiff=1 |
Windows 10 has 4 themes - High Contrast ietf-tools/ietf-at-ui#1, ietf-tools/ietf-at-ui#2, White, and Black. I happen to like High Contrast ietf-tools/ietf-at-ui#1 the best, but none of them show any differences between URL 1 and URL 2. |
@SpencerDawkins thanks for testing and confirming the issues. |
I can confirm it because I am the youngest generation who has gone to work with his elders. |
Description
This may be the lowest priority enhancement request you get in the 2020s, but I wanted to let someone know what I know.
I happened to notice that Windows 10 supports a "High Contrast" setting this morning, and turned it on. Yes, I know this means I am old. 😉
It seems to work well enough for me to want to leave it turned on, but I was just assigned an ART-ART re-review of https://datatracker.ietf.org/doc/draft-ietf-alto-new-transport/, so the next thing I did, was to select the "htmlized" format, and look at a side-by-side diff of -01 (which I had previously reviewed) and -07.
This is what I was looking for (assuming you have something like normal color settings on your computer):
https://author-tools.ietf.org/iddiff?url1=draft-ietf-alto-new-transport-01&url2=draft-ietf-alto-new-transport-07&difftype=--html
This what I got (assuming that I'm attaching a screenshot correctly):
In case the screenshot isn't clear for you, I don't see any color differentiation for new or deleted text, etc. between the two versions.
I have more than one computer, and I can easily enough go find another computer to write my review, or (if I'm traveling and have access to only one computer), turn High contrast mode OFF, but I don't know whether any current or future IETF participants need High contrast mode as more than a convenience, so I thought I'd leave this here, in case the enhancement matters more to other people than it does to me.
Thanks for all you do, by the way. I know these tools don't write, enhance, or fix themselves.
Code of Conduct
The text was updated successfully, but these errors were encountered: