Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Microsoft Windows High contrast mode in iddiff #437

Open
1 task done
SpencerDawkins opened this issue Mar 16, 2023 · 9 comments
Open
1 task done

Support for Microsoft Windows High contrast mode in iddiff #437

SpencerDawkins opened this issue Mar 16, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@SpencerDawkins
Copy link

SpencerDawkins commented Mar 16, 2023

Description

This may be the lowest priority enhancement request you get in the 2020s, but I wanted to let someone know what I know.

I happened to notice that Windows 10 supports a "High Contrast" setting this morning, and turned it on. Yes, I know this means I am old. 😉

It seems to work well enough for me to want to leave it turned on, but I was just assigned an ART-ART re-review of https://datatracker.ietf.org/doc/draft-ietf-alto-new-transport/, so the next thing I did, was to select the "htmlized" format, and look at a side-by-side diff of -01 (which I had previously reviewed) and -07.

This is what I was looking for (assuming you have something like normal color settings on your computer):

https://author-tools.ietf.org/iddiff?url1=draft-ietf-alto-new-transport-01&url2=draft-ietf-alto-new-transport-07&difftype=--html

This what I got (assuming that I'm attaching a screenshot correctly):

image

In case the screenshot isn't clear for you, I don't see any color differentiation for new or deleted text, etc. between the two versions.

I have more than one computer, and I can easily enough go find another computer to write my review, or (if I'm traveling and have access to only one computer), turn High contrast mode OFF, but I don't know whether any current or future IETF participants need High contrast mode as more than a convenience, so I thought I'd leave this here, in case the enhancement matters more to other people than it does to me.

Thanks for all you do, by the way. I know these tools don't write, enhance, or fix themselves.

Code of Conduct

@SpencerDawkins SpencerDawkins added the enhancement New feature or request label Mar 16, 2023
@SpencerDawkins
Copy link
Author

If this enhancement seems interesting to anyone reading this, most of the people I know who work on IETF tools use iOS computers, so if you'd like someone to investigate further on Windows systems (for example, check out High contrast on Windows 11), please hit me up. I'd be happy to do so ...

@kesara
Copy link
Member

kesara commented Mar 18, 2023

We will need to comeup with better colour scheme.
Ref: https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Perceivable/Color_contrast

@SpencerDawkins
Copy link
Author

@kesara - thank you for taking a look at this.

I wasn't sure whether changing the colour scheme would fix this problem, or whether High Contrast on Windows was keying off something else. This is what GitHub looks like, in High Contrast, for instance.

image

Does this look like the colours are being used to show the sharp delimiters (say, around this text box, or is something else happening?

(I ask, because UI is FAR from my area of clue!)

@kesara
Copy link
Member

kesara commented Mar 28, 2023

@SpencerDawkins Thanks for offering to help to test on the Windows platform.
Do you have the same issue with
Can you compare outputs:

@SpencerDawkins
Copy link
Author

@kesara - my apologies for an insanely late reply (jet lag plus another run through COVID-19 after arriving back in DFW was not helpful).

I took a quick look at the links you provided, and I can't see the difference (nor can I see additions and deletions using either version of the diff tool).

This is iddiff=1

image

@SpencerDawkins
Copy link
Author

I should also say that I turned on high contrast mode with no changes to the default colors. This is what I'm using - it's not clear whether any other colors might be better or worse.

image

@SpencerDawkins
Copy link
Author

Windows 10 has 4 themes - High Contrast ietf-tools/ietf-at-ui#1, ietf-tools/ietf-at-ui#2, White, and Black. I happen to like High Contrast ietf-tools/ietf-at-ui#1 the best, but none of them show any differences between URL 1 and URL 2.

@kesara
Copy link
Member

kesara commented Apr 26, 2023

@SpencerDawkins thanks for testing and confirming the issues.

@rungrotArunon
Copy link

I can confirm it because I am the youngest generation who has gone to work with his elders.

@kesara kesara transferred this issue from ietf-tools/ietf-at-ui Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants