Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings: updating request@2 to the latest should fix it #33

Open
icyflame opened this issue Aug 7, 2017 · 5 comments
Open
Labels

Comments

@icyflame
Copy link
Owner

icyflame commented Aug 7, 2017

image

@Jan-Ka
Copy link
Contributor

Jan-Ka commented Oct 1, 2017

Upgrading the packages with a tool like ncu get's rid of all but one deprecation warning.

It seems that two of the used packages use deprecated "node-uuid" library.
Only way to get rid of this is to replace the packages or ignore for now and hope that newer versions will get rid of it.

~/Projects/cli-cube-timer: grep -R "node-uuid"
[...]
node_modules/http-signature/package.json:    "node-uuid": "^1.4.1",
node_modules/request/package.json:    "node-uuid": "~1.4.7",
[...]

However none of these packages are direct dependencies of cli-cube-timer, so maybe best course of action is to actually upgrade the packages and ignore the remaining warnings.

@icyflame
Copy link
Owner Author

icyflame commented Oct 3, 2017

Okay. So, please read my comments on #41 before reading the following comment. (this won't make sense otherwise, sorry 😛 )

I just wanted to remove the deprecated package warnings, I am not necessarily interested in upgrading package versions. (A lot of APIs have changed, eg: Some of Sindre Sorhus's packages have all moved to promises whereas they weren't before.)

ncu is a good tool. I might use it on a dependency-by-dependency basis. But doing everything at the same time is not the way to go.

Merging of the three trash modules into one is the main culprit. I don't even see the use of trash in this particular module.

@icyflame
Copy link
Owner Author

icyflame commented Oct 3, 2017

Okay, I remember now, so actually I removed the trash module. That was the point of v0.8.2

Instead, I started renaming the files and keeping them around anyway. (Through some weird issue, I lost a large set of times. They were backed up in the gist but the pushed.csv file suddenly became empty! I realized it was related to the trashing of times.csv files and a coincidental API error.)

I will check once again to see if there are any deprecated package warnings.

@icyflame
Copy link
Owner Author

Updated warnings:

$ npm i
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130

> [email protected] postinstall /media/siddharth/code/personal-projects/cli-cube-timer/node_modules/spawn-sync
> node postinstall

@icyflame
Copy link
Owner Author

Both node-uuid and tough-cookie are dependencies of [email protected]. These have probably been fixed in the latest version of request.

@icyflame icyflame changed the title Take care of all the deprecated packages warnings Deprecation warnings: updating request@2 to the latest should fix it Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants