-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings: updating request@2 to the latest should fix it #33
Comments
Upgrading the packages with a tool like ncu get's rid of all but one deprecation warning. It seems that two of the used packages use deprecated "node-uuid" library. ~/Projects/cli-cube-timer: grep -R "node-uuid"
[...]
node_modules/http-signature/package.json: "node-uuid": "^1.4.1",
node_modules/request/package.json: "node-uuid": "~1.4.7",
[...] However none of these packages are direct dependencies of cli-cube-timer, so maybe best course of action is to actually upgrade the packages and ignore the remaining warnings. |
Okay. So, please read my comments on #41 before reading the following comment. (this won't make sense otherwise, sorry 😛 ) I just wanted to remove the deprecated package warnings, I am not necessarily interested in upgrading package versions. (A lot of APIs have changed, eg: Some of Sindre Sorhus's packages have all moved to promises whereas they weren't before.)
Merging of the three trash modules into one is the main culprit. I don't even see the use of trash in this particular module. |
Okay, I remember now, so actually I removed the trash module. That was the point of v0.8.2 Instead, I started renaming the files and keeping them around anyway. (Through some weird issue, I lost a large set of times. They were backed up in the gist but the pushed.csv file suddenly became empty! I realized it was related to the trashing of times.csv files and a coincidental API error.) I will check once again to see if there are any deprecated package warnings. |
Updated warnings: $ npm i
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
> [email protected] postinstall /media/siddharth/code/personal-projects/cli-cube-timer/node_modules/spawn-sync
> node postinstall |
Both |
The text was updated successfully, but these errors were encountered: