Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define slot later on #6

Open
ppalladino opened this issue Nov 3, 2014 · 3 comments
Open

Define slot later on #6

ppalladino opened this issue Nov 3, 2014 · 3 comments

Comments

@ppalladino
Copy link

This may be a dupe of #4, but I need to define slots later on rather than in the module config. The ad's ids, tags, etc. are managed in our CMS and come down into the client application via a $resource service inside of a controller. I tried to hack the service returned via the DoubleClickProvider to update the slots array but no luck. Any tips for this matter would be greatly appreciated. Thanks!

@ianmurrays
Copy link
Owner

You may need to play around with google's API first and see if it is actually possible (I'm sure it is, but I don't know). After that, I guess somehow moving the defineSlot method to the $get factory should enable you to add more slots and from there update the google library.

Not sure if what I said makes sense :)

@ppalladino
Copy link
Author

After digging into the code a bit more, yeah, that does make sense. I see that the slots are sent to google in the provider's init call. If I get some extra time, I'll see if I can fool around with extending the $get factory. Thanks for the quick response!!!

@deonheunis
Copy link

Has anyone got this to work ? Happy to pay someone for this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants