Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parameterize ezEth Config Getter #5338

Merged
merged 25 commits into from
Feb 3, 2025
Merged

feat: Parameterize ezEth Config Getter #5338

merged 25 commits into from
Feb 3, 2025

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Jan 29, 2025 •
edited
Loading

Description

This PR updates the ezEth Getter into a function that accepts xERC20 and Safe addresses.

Related issues

Backward compatibility

Yes

Testing

Manual/Unit Tests

ltyu added 13 commits December 26, 2024 18:28
@ltyu
Split safes and tokens to separate environments (staging and prod). A…
2b36963 
…dd pzEth getter
@ltyu
Revert "Split safes and tokens to separate environments (staging and …
0f9578a 
…prod). Add pzEth getter"

This reverts commit 2b36963.
@ltyu
Move staging safes
4a37858
@ltyu
Merge branch 'main' into ltyu/deploy-pzEth-staging
a17a882
@ltyu
Revert "Move staging safes"
a7bbd52 
This reverts commit 4a37858.
@ltyu
Add getRenzoEZETHWarpConfigGenerator
e8ea443
@ltyu
Move functions around in attempt to reduce diffs
f46f2df
@ltyu
Move functions around in attempt to reduce diffs
5ef2b24
@ltyu
Revert "Move functions around in attempt to reduce diffs"
93caee9 
This reverts commit 5ef2b24.
@ltyu
Revert "Move functions around in attempt to reduce diffs"
6c28235 
This reverts commit f46f2df.
@ltyu
Export chainsToDeploy
31187ae
@ltyu
Add Staging config generator
5ed5086
@ltyu
Fix conflicts - ezEth config
9bad3e8
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 765ec30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ltyu ltyu marked this pull request as ready for review January 30, 2025 20:19
@ltyu ltyu requested a review from yorhodes January 30, 2025 20:25
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (30eeecf) to head (765ec30).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5338   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ltyu ltyu force-pushed the ltyu/ezEth-staging-config branch from 4fc85f6 to 7788cbb Compare January 31, 2025 17:05
@mergify mergify bot mentioned this pull request Feb 3, 2025
Open
@ltyu ltyu enabled auto-merge February 3, 2025 20:16
@ltyu ltyu changed the title feat: Add ezEth Staging Config feat: Parameterize ezEth Config Getter Feb 3, 2025
@ltyu ltyu added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit dc0fe6c Feb 3, 2025
46 checks passed
@ltyu ltyu deleted the ltyu/ezEth-staging-config branch February 3, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@Mo-Hussain Mo-Hussain Awaiting requested review from Mo-Hussain Mo-Hussain is a code owner

@yorhodes yorhodes Awaiting requested review from yorhodes

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: update ezEth getter to accept safe and xerc20 addresses
2 participants
@ltyu @nambrot