Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cancellation in deployers #5323

Open
jmrossy opened this issue Jan 29, 2025 · 0 comments
Open

Support cancellation in deployers #5323

jmrossy opened this issue Jan 29, 2025 · 0 comments

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Jan 29, 2025

Problem

Once a deployment triggered (e.g. via await MyDeployer.deploy()), there is no good way to stop it. The Deploy App hacked cancellation support by bricking the multiProvider passed into the deployer but it's not super reliable. The proper solution would be to have the deployers check for cancellation requests in between read/write calls and bail if needed.

AbortController may help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant