Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos tx inclusion is not awaited for in the submit step #5311

Open
Tracked by #3321
tkporter opened this issue Jan 28, 2025 · 0 comments
Open
Tracked by #3321

Cosmos tx inclusion is not awaited for in the submit step #5311

tkporter opened this issue Jan 28, 2025 · 0 comments
Labels
agent alt-VM non-EVM alternative execution environment cosmos solana move cardano polkadot bug Something isn't working cosmos

Comments

@tkporter
Copy link
Collaborator

tkporter commented Jan 28, 2025

Was poking around the explorer and noticed that some Neutron destination messages weren't immediately processed.

Taking a look at the logs for https://explorer.hyperlane.xyz/message/0x5eff3922f7cae967815a5ac19f934c5d7dde07136f613c4569c0affd26414d47:

We hit account sequence # mismatches pretty frequently (i.e. nonce issues). The reason is that we expect our call to mailbox.process to await tx inclusion (EVM and SVM impls do this), but on Cosmos we seemingly don't. Logs https://cloudlogging.app.goo.gl/GE2RfeUgMi1UPZ3R8 and https://cloudlogging.app.goo.gl/iEGwjyaGyM2ptnLV7.

We use broadcast mode Sync https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/rust/main/chains/hyperlane-cosmos/src/providers/grpc.rs#L598, which according to cosmos/cosmos-sdk#4186 (comment) means that it just passes basic validity of the tx but not that it's landed in a block.

This also means that the gas used we get back from there etc isn't canonical.

So concretely we should:

  • make sure the process fn for our Cosmos impl awaits tx inclusion, likely by having some logic that polls for delivery

Related: #5310

@tkporter tkporter added agent alt-VM non-EVM alternative execution environment cosmos solana move cardano polkadot bug Something isn't working cosmos labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent alt-VM non-EVM alternative execution environment cosmos solana move cardano polkadot bug Something isn't working cosmos
Projects
Status: No status
Development

No branches or pull requests

1 participant