Skip to content

Latest commit

 

History

History
33 lines (17 loc) · 1.38 KB

043.md

File metadata and controls

33 lines (17 loc) · 1.38 KB

moneyversed

medium

No events for actions related to the _approvedForwarderSenders mapping

Summary

There are no events for actions related to the _approvedForwarderSenders mapping, making it hard to track and monitor changes to the trusted forwarders.

Vulnerability Detail

The TellerV2Context.sol contract does not emit any events when updating the _approvedForwarderSenders mapping. This makes it difficult to monitor and track changes to the trusted forwarders, reducing the transparency and auditability of the contract.

Impact

Reduced transparency and auditability, making it harder to monitor changes to the trusted forwarders.

Code Snippet

https://github.com/sherlock-audit/2023-03-teller/blob/main/teller-protocol-v2/packages/contracts/contracts/TellerV2Context.sol#L61

https://github.com/sherlock-audit/2023-03-teller/blob/main/teller-protocol-v2/packages/contracts/contracts/TellerV2Context.sol#L94

https://github.com/sherlock-audit/2023-03-teller/blob/main/teller-protocol-v2/packages/contracts/contracts/TellerV2Context.sol#L116

Tool used

Manual Review

Recommendation

Consider adding events that are emitted when actions related to the _approvedForwarderSenders mapping are performed, such as adding or removing trusted forwarders. This will improve the transparency and auditability of the contract, making it easier to monitor changes to the trusted forwarders.