Skip to content

Latest commit

 

History

History
31 lines (16 loc) · 1.09 KB

037.md

File metadata and controls

31 lines (16 loc) · 1.09 KB

moneyversed

medium

Function visibility

Summary

The setTrustedMarketForwarder and approveMarketForwarder functions are marked as external. This may expose them to potential attacks. It is recommended to use internal or private visibility for better security.

Vulnerability Detail

The setTrustedMarketForwarder and approveMarketForwarder functions have external visibility, which could expose them to potential attacks. Using internal or private visibility would provide better security.

Impact

The exposed functions could be exploited by malicious actors, potentially compromising the security of the platform.

Code Snippet

https://github.com/sherlock-audit/2023-03-teller/blob/main/teller-protocol-v2/packages/contracts/contracts/TellerV2Context.sol#L70

https://github.com/sherlock-audit/2023-03-teller/blob/main/teller-protocol-v2/packages/contracts/contracts/TellerV2Context.sol#L87

Tool used

Manual Review

Recommendation

Change the visibility of the setTrustedMarketForwarder and approveMarketForwarder functions to internal or private to improve the security of the platform.