Swedish Language Leader

[synesthesiam]

@lellky are you interested in being the Swedish language leader? Another person from Discord has volunteered; I'll point them to this issue.

[edgein666]

Hi, the person from Discord here.. 🙂 let me know if I can help. BR Björn

[larsdunemark]

I can also help out with this if there is need for multiple workers or a work group.

[lellky]

Good morning!

I am interested, and it would be an honor, but I have two younglings here at home and I don't know if I have the time to fully commit to be the leader. I will gladly help with reviews and have discussions though.

Also, there is another user thedailyuncle on discord: https://discordapp.com/channels/330944238910963714/1054846248374505572/1056591259944370186

[synesthesiam]

No worries, @lellky. Is anyone else interested in being a Swedish language leader? I've invited "thedailyuncle" from Discord to join us here too.

[larsdunemark]

I can take the role of language leader for Swedish, if someone else would also like to be involved, I think it would be great to share the work with me because it would be my first assignment in an open source project.

[edgein666]

I have nothing against you taking the role Lars and I would be happy to share the work with you. We could get the work going with some Discord calls maybe? I don't have much experience with GitHub and open source projects but we could probably work it out together. BR Björn

[ph13t0n]

Hi Synesthesiam,

I hope this message finds you well. I am writing because I previously expressed my interest in the open position as a translator. I am confident that my skills and experience make me a strong fit for the role.

Thank you for considering my application. I look forward to the opportunity to contribute to your team.

Sincerely,
Per Rudhamn, thedailyuncle#5220 @ discord.

[edgein666]

Hi Per,

Just to double check, have you seen the release party yesterday where they asked the community for language leaders?

If not; the leader would get the responsibility to validate and approve the submissions from, I guess, anyone who wants to contribute.

Someone please correct me if I misunderstood.

So, if you just want to translate, please go ahead. If you want to be the leader, maybe check with Lars who has also shown interest.

My suggestion is that we try and work as a team but with one leader. As I mentioned in a previous comment I am myself not sure how all of this works but I'm happy to help out.

BR Björn

[ph13t0n]

Hi Björn!

You seems suitable for the task, i only responded to a reply and announced that I'm here.

All the tasks, events and newsletters who has been released from HQ, has been reviewed and fully understand in what will come, in the near time and in the future and I guess, with all good intentions that a leader should bring people, is to get them together, lift and inspire members to do good and as you, suggested - maybe a little, harsh - I can not lead when the first suggestion and response is to go away and "just translate" when this is my first contact to a great team.

And as you probably know, every bit counts, to give the end-user a fantastic experience and enjoy a great version of Home Assistant, now and forever.

That is my beacon, that is my goal with everything I do.

I go forward and "just translate" and skip the leadership - may the force be strong!

//Per Rudhamn

[synesthesiam]

The language leader(s) will be responsible for reviewing and merging PRs. Of course, they can contribute translations as well 🙂

[larsdunemark]

I feel like handling PR and reviewing shouldn't be an issue, finding the right level for the linguistic part may be my bigger challenge and I think that it will benefit from multiple reviewers to get it as smooth as possible.

[ph13t0n]

Lars!

well written - you can't spell team with an "I", it's impossible. Enjoy the ride //Per

[Robin-St]

I think the part of handling the level of the linguistics is a good part for group collaboration. Whenever in doubt just start a discussion at the relevant PR and tag those of us that usually add insights.

[synesthesiam]

Just merged a PR from @Robin-St. Tagging them here for language leader discussion.

[Robin-St]

Thanks, I thought about applying but think I have to pass on formal responsibilities for now. But I’m really interested in helping with discussions and writing intents. (And down the road start to test and use HA with local voice :) )

[edgein666]

Great work @Robin-St! I saw your translation and also that @larsdunemark has pushed something.

Would anyone of you mind showing me your workflow? I have vscode and I am using GitHub with my personal account. The files with the translations seems pretty straight forward. But I have some gaps and would appreciate some help connecting the dots.

Discord EdGe#8257

[Robin-St]

@edgein666 I just followed this https://github.com/home-assistant/intents/blob/main/docs/codespace/README.md to set up a codespace. It was really easy and convenient and gave a virtual machine running at github with all dependencies and vscode right in the browser, but from the top left menu you can choose to open it in the desktop editor instead which worked great (still connected to the VM in the cloud).

[edgein666]

I saw your post but never read the article, was so sure that there would be a cost for me personaly. Just checked and this seems like the way to go for me. Thanks :)

[edgein666]

Just made PR #499 but not sure it's done correctly. Comments appreciated. :)

[Robin-St]

The added intent variations looks good but the bot seems to be upset with some git technicalities. I'm guessing that the commits are done by a local user and not your gitlab user. Did you use a codespace or check out the code locally?

[edgein666]

Yeah, I had one issue with the mail-address, so added the additional address, then I had to sign some "CLA". Both should be fixed. Might just be that I need to be approved by a person? "1 workflow awaiting approval"

I made a fork, opened it with vscode, then pushed the changes and then clicked on "create pull request" in the github webpage, that created #499 and then I had to add the mail and the CLA as mentioned above.

Maybe I'm good and just need to wait for @synesthesiam or someone to approve me?

[Robin-St]

Partly good. The addition to _common.yaml works right away. But for the light set you have added good tests and found a "ändra" but you have missed to update the actual intent. The intent is coded in https://github.com/home-assistant/intents/blob/main/sentences/sv/light_HassLightSet.yaml and to that file "ändra" needs to be added to the list of words to use.

There are test scripts that you can run that will test each sentence added to the tests in the test folder against the intents definitions in the sentences folder. Whit these it's easy to add more tests sentences and continuously add or tweak intent definitions until all test sentences are correctly matched :)

[edgein666]

Right, didn't think about that. I will look into it, thanks!

[edgein666]

Question about:

• "[sätt | vrid | dra [på] | skruva | dimmra] [upp | ner ] [s | n | ns ] [] till "

in:
https://github.com/home-assistant/intents/blob/main/sentences/sv/light_HassLightSet.yaml

Are, let's say, [upp | ner ] mandatory? That is; either "upp" or "ner"? Can it be silent? If not, how can we accomplish that?

//Björn

[Robin-St]

"[ ]" is optional and "( )" mandatory.
https://github.com/home-assistant/intents/blob/main/sentences/README.md#sentence-templates

[edgein666]

Btw, shouldn't we use variables in this file as well? Like we have in the on/off files? In the name of consistency.

[Robin-St]

Yes, i started to do that in a pull request that haven been merged yet. #487

[Robin-St]

Regarding entity id for test fixtures, there where a mix of English and Swedish names for the entity id's for the fixtures both areas and items. I made a pull request that has the names in Swedish but all id's in English, as it feels more natural to have "variable" names in English for me. The same pull request also clears up some duplicate areas for different endings for kitchen (as the different spellings had different id the tests started to fail when i added logic to handle all different endings for rooms)

Does anyone here have an opinion regarding the language of the id's? I can remake them in Swedish if we prefer that, i just want it consistent :)
#497

[edgein666]

I agree, English and consistent. 👍

[lellky]

I also agree. The id's could be in english (although my id's in my home assistant instance are in Swedish).

[lellky]

A general question about naming devices/entities/areas;

In my Home Assistant I have areas (in Swedish) like:

• Vardagsrummet (the living room)
• Köket (the kitchen)
• Sovrummet (the bedroom)

and entities/devices like:

• Kökslampan (the kitchen lamp)
• Taklampan i vardagsrummet (the ceiling lamp in the living room)
• Golvlampan i vardagsrummet (the floor lamp in the living room)
• Temperatur i sovrummet (the temperature in the bedroom)
• Jonas sänglampa (Jonas's bedside lamp)

Do we know how people in general name their devices/entities/areas and how will this be handled in general considering the examples above containing the area (in the name)? Also some people seem to name their areas in definite form and others in indefinite form (vardagsrummet/the living room v.s. vardagsrum/living room).

[Robin-St]

I would guess that there are a mix of detailed naming as your and more loose naming. With the recent ability to have multiple names for entities i would think that there might be good cases to name a lamp "Taklampa Sovrum" and "Taklampa" just to be able to address it by a unique name or a combination of area and not unique name.

Regarding naming areas, i hope that the following rules will expand most (all?) room names but have not done extensive testing:

  name: "{name}[s | n | ns | en ]"
  area: "{area}[e | me][t | ts | n | ns ]"

[edgein666]

Hi,

trying to understand git and github. right now we have 5 Open pull requests of different files, can I open the same file and modify it or will something get messed up with the versioning? I guess git is done for this but I'm clueless about how it should work.

BR Björn

[larsdunemark]

When a commit is merged the changes in that commit will be added to the main branch. Before that it doesn't matter. But if there is another commit modifying the same file there will be a merge conflict that will need manually correction. This is usually fixed by rebase your commit on the latest main branch.

[edgein666]

Ok, thanks for the explanation.

So if I want to change one of the files currently in the queue to be approved and merged, should I wait until they are merged and do a new pull (?) and then make my change?

What is the best approach?

[Robin-St]

Best approach is a tricky question. The risk of waiting for the right opportunity is to always miss "the window" and the risk of not waiting is the potential added work to merge. It is easier to add things to the same file than it is to modify the same lines, just something to get a feel for :) But to get going i would say not to wait, build more momentum and get up to speed and then we can help resolve the merges.

If you want to see live example look at #487. The first two commits where before i opened the PR and all tests against main where running ok. Then #497 that where submitted after got merged into main, making the modification not work and the tests fail. Then opened up that branch in vs-code again and pulled latest main and selected to merge that into this branch. While doing so git merges the changes that have no conflicts and asks for the changes that where done to the same places of the code which to keep.

With the changes from main now in the branch i ran the tests, looked at the errors and fixed the compatibility so that the change now works with the new main. Buy just committing these changes to the branch they are visible from the PR and the tests now run again :D

[edgein666]

Still figuring things out.. Did #580 now. Let me know what/if something is wrong. :)

[lellky]

I recommend reading this article: https://medium.com/singlestone/a-git-workflow-using-rebase-1b1210de83e5

Also, keep in mind that the more open pull requests the more complexity and risk for merge conflicts. It is always a good idea to make small changes in a pull request and try to get them merged before opening new pull requests. Also rebasing on upstream (main repo) is a must and is described in the article linked above.

[synesthesiam]

@larsdunemark adding you as language leader 👍

[Robin-St]

@larsdunemark If you want some second eyes for the language part of your commits you can ping me, if it helps :)

[lellky]

You can ping me as well.

[edgein666]

I'm also trying to be here. :)

[synesthesiam]

@larsdunemark You're free to merge PRs that look good, but I would suggesting tagging others for feedback 🙂

[larsdunemark]

It doesn't look like I can take a person that is not part of the HA group or not already part for the MR so if anyone would like to put a comment on my MR #433 it would be great.

[Robin-St]

Just for fun i tested the sampling feature to see how many sentences are recognized. For HassTurnOn we have 56035 different sentences with all variations of letter, a lot of these sentences does not make sense, but still a huge number. Also made the mistake to run it for all intentions, but as it generated a sentence for each variation of the commands for each set brightness percentage i had to stop the script

[edgein666]

Swenglish: Many variations it will become. :)

[synesthesiam]

Keep in mind that the goal for this repo is to just have very common ways of saying things. Users will always have the option to create custom sentences.

[edgein666]

thanks @synesthesiam very good to know!

[djungelola]

Hi, my first test of Assist was turning on a light and my first choice was "Tänd lampan i köket" but didnt work.
Saw in the yaml that "Slå på/av" is what was defined. Possible to add "Tänd" and "Släck" for lights?
That feels more natrual to me atleast.

/Ola

[larsdunemark]

Hi @djungelola
We are using the template variable {slå_på} and {slå_av} that should resolve to contain "Tänd" and "Släck"
https://github.com/home-assistant/intents/blob/main/sentences/sv/_common.yaml#L61-L62
I started testing it out for some parts last night but haven't had time to verify all scenarios. It seems that there might be some issues left when matching sentences.
Did it work with "slå på lampan i köket" or did that also fail?

[lellky]

Is your Home Assistant running in Swedish or English? It seems to work only in the language set for Home Assistant, i.e. if Home Assistant is set to English the assist feature will only recognise English input.

[djungelola]

Yes, you are right!
"Tänd/Släck alla lampor i köket" works.
"Slå på/av alla lampor" i köket works.
"Tänd/Släck lamporna i köket" doesnt work, but might be as designed maybe?

Either way, thanks for driving this in Swedish!!

Br Ola

[edgein666]

that is strange..

"släck/tänd lamporna i köket" works for me!

[djungelola]

it worked for me now as well, maybe SBS on my side :-)
Will continue testing.

[lellky]

Glad to hear!

[mrdanielk1]

Hello, fellow Swedes,

I'm having big problems getting Assist to understand what I type (and also say). As soon as I add an area to the sentence, it fails. Either with "Ett oväntat fel.." or "ursäkta, jag förstår inte".

My setup is fairly basic, I have some rooms, and in the rooms I have some devices. Nothing fancy. Most of the devices are connected through Telldus. Not that it should matter. Language is set to Swedish.

Anyway, I have window lamps in several rooms. They are all named "Fönsterlampa". But they are connected to different areas. The areas are named "Kök", Allrum" and so on.

In Assist, If I type "Tänd fönsterlampan i köket", I would expect the window light in the kitchen to be activated, but it fails with "Ursäkta, jag förstår inte". If I omit the area, and type: "Tänd fönsterlampan", it does turn one of the window lights on, but I can't control which one.

I have tried all kinds of tricks to get it to work, but the areas always make it fail. I've tried all kinds of grammar differences to try to fix it, like "Tänd fönsterlampa i kök", but it makes no difference. I've also tried simple phrases like "Tänd alla lampor i kök", but those cause "Oväntat fel..."

Any ideas what I'm doing wrong?

Thanks in advance.
/Daniel.

[edgein666]

Hi,

first of all, thanks for testing!

I tried "tänd sänglampan på ovanvåningen" which is similar to your sentence and it doesn't work either.

But "tänd sänglampan" works.

I guess the intent should match a sentence in this file:
https://github.com/home-assistant/intents/blob/main/sentences/sv/light_HassTurnOn.yaml

But I cannot find it.

I think we need to add something like:

"<slå_på> <name> <i_på> <area>"

these are the variables:

slå_på: "(tänd | sätt (på | igång | fart på) | slå (på | till) | starta)"
name: "{name}[s|n|ns|en]"
i_på: "(i | på | vid | bredvid)"
area: "{area}[e|me][t|n][s]"

also pinging @larsdunemark and @Robin-St for comments.

//B

[edgein666]

I have added "[SV] Possibility to turn on light in area. #933" to solve this.

[mrdanielk1]

Awesome. Thanks for the quick response. :)

I have looked at the files and assumed that "<slå_på> [<alla>] <ljuskällor> <i_på> <area>" would cover my use case, since I assumed [<alla>] was optional. But I was clearly wrong.

However, "Tänd alla lampor i köket" also fails for me with "Oväntat fel...". @djungelola (a few posts up) seems to have success with that. I cannot refer to any area with "alla lampor"

So I'm still feeling that my areas cause problems...

Thanks again!

/D

[mrdanielk1]

Quick update, some areas seem to work. "allrummet" and "sovrummet" works with "alla lampor". "vardagsrummet", "köket" and "arbetsrummet" does not...

Strange...

[synesthesiam]

@larsdunemark when you get a chance, could you please look into translating the HassGetState sentences/responses?

[slungs]

Hi, is @larsdunemark still acting as language leader for Swedish? I just got my voice PE and the experience with swedish... well, still needs some improvement. Happy to help in any way possible.

/Anton

[larsdunemark]

Sure is, if you find something that you are missing and have the possibility to add a PR I will make sure that we can merge it.