Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class GetInvoiceListHandler invalid Namespace #22

Open
DangerLifter opened this issue Dec 13, 2019 · 3 comments
Open

Class GetInvoiceListHandler invalid Namespace #22

DangerLifter opened this issue Dec 13, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@DangerLifter
Copy link

DangerLifter commented Dec 13, 2019

namespace BolCom\RetailerApi\Handler\Invoice; must be instead of namespace BolCom\RetailerApi\Handler\Commission;

Same is about GetInvoiceHandler

@JeroenVanLeusden JeroenVanLeusden self-assigned this Dec 16, 2019
@JeroenVanLeusden JeroenVanLeusden added the enhancement New feature or request label Dec 16, 2019
@JeroenVanLeusden
Copy link

JeroenVanLeusden commented Dec 16, 2019

@DangerLifter Invoices are there as a draft and not fully implemented yet. We'll discuss this with bol.com but I don't think it will be anytime soon this will be implemented.

@DangerLifter
Copy link
Author

@DangerLifter Invoices are there as a draft and not fully implemented yet. We'll discuss this with bol.com but I don't think it will be anytime soon this will be implemented.

I guess, in spite of bol.com does not support invoice, it is not a reason to have Invalid class names

@adriaanzon
Copy link

When running composer install with the latest version of Composer (v1.10) it also warns about classes not complying with the PSR-4 autoloading standard, saying that the classes won't be loaded by the autoloader in Composer v2.0.

Deprecation Notice: Class BolCom\RetailerApi\Handler\Commission\GetInvoiceListHandler located in ./vendor/bol-com/retailer-api/src/Handler/Invoice/GetInvoiceListHandler.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\Handler\Commission\GetInvoiceHandler located in ./vendor/bol-com/retailer-api/src/Handler/Invoice/GetInvoiceHandler.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\Handler\Commission\GetInvoiceSpecificationHandler located in ./vendor/bol-com/retailer-api/src/Handler/Invoice/GetInvoiceSpecificationHandler.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\Test\Integration\Handler\Order\GetShipmentHandlerTest located in ./vendor/bol-com/retailer-api/src/Test/Integration/Handler/Shipment/GetShipmentHandlerTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\Test\Integration\Handler\Commission\AssertEanTest located in ./vendor/bol-com/retailer-api/src/Test/Integration/AssertEanTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\Model\Transport\QueryHandler\AddTransportInformationHandler located in ./vendor/bol-com/retailer-api/src/Model/Transport/CommandHandler/AddTransportInformationHandler.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetFbbTransporterListHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetFbbTransporterListHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetDeliveryWindowHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetDeliveryWindowHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetInboundHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetInboundHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetPackingListHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetPackingListHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetInboundListHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetInboundListHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetInventoryListHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetInventoryListHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class BolCom\RetailerApi\CommandHandler\Inbound\Query\GetFbbShippingLabelHandlerInterface located in ./vendor/bol-com/retailer-api/src/Model/Inbound/QueryHandler/GetFbbShippingLabelHandlerInterface.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.0/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants