-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of RSU vest dates should not impede migration to new sheet versions #9
Comments
Added some guidance to README.md about how to add RSUs privately, and an undertaking not to break copy/paste compat between sheet versions again as it's such a pain. Perhaps add a hidden date field to each row which is when it's added, and a version picker for the version of the sheet we're transferring from.
That should result in correctly padding the old data into the new row layout... but maybe not worth it and doesn't help with privately added rows. |
If I understand this, the requirement is to adjust the table in the RSU sheet so that for each row, the "Market Value Per Share" is populated according to the date in the "Release Date" column. One approach would be to create a new sheet that only contains two columns: Release Date and Market Value Per Share. (Copy them from the existing RSU sheet to columns A and B in the new sheet.) With a title in row one, this would be referred to as: RSUprices!$A2:$B and more values can be added as needed later, if they are contributed by others. Then in the RSU sheet, use a VLOOKUP formula in column E, which is currently a static Market Value in rows 5 through N. More rows can be inserted, as long as formulas in all columns are copied. For any (valid) date in RSU sheet column C, the price will be reflected in column E. Column C could also use data validation to only allow dates to be chosen from the table sheet. This formula would be something like this in column E row 5, then copy down the sheet as needed:
With that tweak, you can have any number of rows on the RSU sheet, and the values can be copied and pasted from older versions of the spreadsheet. Only copy columns C, D, and F. The formula is in E. |
Thanks! I'll give that a go. I'm basically new to spreadsheets and wasn't aware of VLOOKUP. It's a little more involved because of the following condition:
I'll definitely give it a go with VLOOKUP. If not my fallback will be AppScript - that's surprisingly easy once you start... although love/hate for javascript. |
Glad you think it might be useful. I believe it would handle multiple rows on the RSU sheet with the same date, and if there is a date with missing price info, the example formula above outputs "No price found" so that would be a hint to resolve the problem. I just sent you a Slack DM on the Turtle Pond with a prototype if you are interested. Thank you for leading the charge on this! |
See #59 |
Finally revisited the VLOOKUP and figured out why it was giving errors for some prices. turns out that creating a view and sorting in ascending order does not meet the "must be sorted" requirement. You either need the raw data fully sorted or to wrap the range reference in I now need to look into why there's a small numeric change when using the resolved data, but basically on track to have this in 0.1.7 🤞 |
This is the primary commit shifting us to using VLOOKUP to get price info based on date, instead of having people enter their share quantities into the "correct" row. This unbounds the lot rows in ESPP & RSU datasheets by removing the bottom totals row, updating any ranges to refer to the entire column from row 7 down. For ESPP the "default" number of lots (ie. rows with formula populated) is set to allow one ESPP lot per 6 months back to 2007 when the current ESPP plan was established. For RSUs the "default" is 150 which is just a guestimate but should suffice for pretty much everyone. Additionally, in ESPP, this adjusts the the carry/contribution formula so that it looks sane if the optional values for contribution aren't filled in. The price information has been sourced from wligithub/tax-tool @ 93c2b2c2 with Wei's permission. See data/vmw-historical-price.csv I validated the prices match with all price information I previously had in the sheet. Tries to improve in-sheet doc by adding Notes to the first entry row of all inputs. Adds sub-headings for Required/Optional in-sheet as the colour coding does not seem to have been effective as a UX indicator. Fixes #9
Updates the doc to reflect new data entry style and starts to detail changes for v0.1.7. Related to #9 Renames merger agreement to html so opening is handled by the appropriate app. Add the v0.1.7 binary sheet.
This is the primary commit shifting us to using VLOOKUP to get price info based on date, instead of having people enter their share quantities into the "correct" row. This unbounds the lot rows in ESPP & RSU datasheets by removing the bottom totals row, updating any ranges to refer to the entire column from row 7 down. For ESPP the "default" number of lots (ie. rows with formula populated) is set to allow one ESPP lot per 6 months back to 2007 when the current ESPP plan was established. For RSUs the "default" is 150 which is just a guestimate but should suffice for pretty much everyone. Additionally, in ESPP, this adjusts the the carry/contribution formula so that it looks sane if the optional values for contribution aren't filled in. The price information has been sourced from wligithub/tax-tool @ 93c2b2c2 with Wei's permission. See data/vmw-historical-price.csv I validated the prices match with all price information I previously had in the sheet. Tries to improve in-sheet doc by adding Notes to the first entry row of all inputs. Adds sub-headings for Required/Optional in-sheet as the colour coding does not seem to have been effective as a UX indicator. Fixes #9
Updates the doc to reflect new data entry style and starts to detail changes for v0.1.7. Related to #9 Renames merger agreement to html so opening is handled by the appropriate app. Add the v0.1.7 binary sheet.
Updates the doc to reflect new data entry style and starts to detail changes for v0.1.7. Related to #9 Renames merger agreement to html so opening is handled by the appropriate app. Add the v0.1.7 binary sheet.
When people contribute additional RSU vest date/price data, or if people have deleted/added rows themselves, it will impede ability to adopt a new sheet version.
Look into means for doing upgrade (why is it always upgrade problems - the repo's been in existence for less than a day!).
This may need ActionScript or Macros to avoid repeated re-entry of data.
The text was updated successfully, but these errors were encountered: