From 70833e1778e68bcd9f7cfafbe9843b1555afd265 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Selen=20S=CC=A7ar?= Date: Fri, 17 Jan 2025 15:40:50 +0300 Subject: [PATCH 1/4] feat: added sass config to webpack server config --- webpack.server.config.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/webpack.server.config.js b/webpack.server.config.js index ab4fc6a..5161070 100644 --- a/webpack.server.config.js +++ b/webpack.server.config.js @@ -77,7 +77,7 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { localIdentHashSalt: packageJson.name, exportOnlyLocals: true, }, - importLoaders: 1, + importLoaders: 2, sourceMap: isDebug, } }, @@ -87,6 +87,11 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { }, { loader: 'sass-loader', + options: { + implementation: require("sass"), + sassOptions: { + outputStyle: "compressed" + } }, ...(voltranConfig.sassResources ? [ From 21ac52ce5017101f7a9a57e1d50c48563cab71e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Selen=20S=CC=A7ar?= Date: Fri, 17 Jan 2025 16:24:19 +0300 Subject: [PATCH 2/4] feat: fix syntax --- webpack.server.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/webpack.server.config.js b/webpack.server.config.js index 5161070..14e40a7 100644 --- a/webpack.server.config.js +++ b/webpack.server.config.js @@ -92,6 +92,7 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { sassOptions: { outputStyle: "compressed" } + } }, ...(voltranConfig.sassResources ? [ From 898f77b24cdc5705ee22b13568187836154e8a52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Selen=20S=CC=A7ar?= Date: Fri, 17 Jan 2025 17:13:19 +0300 Subject: [PATCH 3/4] feat: added server configs for sass --- webpack.server.config.js | 41 ++++++++++++++++++++++++---------------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/webpack.server.config.js b/webpack.server.config.js index 14e40a7..bd39a76 100644 --- a/webpack.server.config.js +++ b/webpack.server.config.js @@ -3,6 +3,8 @@ const webpack = require('webpack'); const {merge} = require('webpack-merge'); const nodeExternals = require('webpack-node-externals'); const {CleanWebpackPlugin} = require('clean-webpack-plugin'); +const MiniCssExtractPlugin = require('mini-css-extract-plugin'); + const env = process.env.VOLTRAN_ENV || 'local'; @@ -67,6 +69,9 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { { test: /\.scss$/, use: [ + { + loader: MiniCssExtractPlugin.loader, + }, { loader: 'css-loader', options: { @@ -75,37 +80,36 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { ? `${voltranConfig.prefix}-[name]-[hash:base64]` : `${voltranConfig.prefix}-[path][name]__[local]`, localIdentHashSalt: packageJson.name, - exportOnlyLocals: true, }, importLoaders: 2, sourceMap: isDebug, - } + }, }, { loader: 'postcss-loader', - options: postCssConfig + options: postCssConfig, }, { loader: 'sass-loader', options: { - implementation: require("sass"), + implementation: require('sass'), sassOptions: { - outputStyle: "compressed" - } - } + outputStyle: 'compressed', + }, + }, }, ...(voltranConfig.sassResources ? [ - { - loader: 'sass-resources-loader', - options: { - sourceMap: false, - resources: voltranConfig.sassResources, + { + loader: 'sass-resources-loader', + options: { + sourceMap: false, + resources: voltranConfig.sassResources, + }, }, - }, - ] - : []) - ] + ] + : []), + ], } ] }, @@ -126,6 +130,11 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { __DEV__: isDebug, }), + new MiniCssExtractPlugin({ + filename: '[name].css', + chunkFilename: '[id].css', + }), + ...(isDebug ? [new webpack.HotModuleReplacementPlugin()] : []) ] }); From 8939b8812d099c91cb003c87391a15651faeefe4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Selen=20S=CC=A7ar?= Date: Mon, 20 Jan 2025 14:22:36 +0300 Subject: [PATCH 4/4] feat: css loader added to server config --- package.json | 2 +- webpack.server.config.js | 27 ++++++++++++++++++++++++++- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index ea50e71..d265b14 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "voltranjs", - "version": "1.1.11", + "version": "1.1.11-beta.0", "main": "src/index.js", "author": "Hepsiburada Technology Team", "bin": { diff --git a/webpack.server.config.js b/webpack.server.config.js index bd39a76..92292f2 100644 --- a/webpack.server.config.js +++ b/webpack.server.config.js @@ -66,6 +66,31 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { multiple: [...replaceString()], }, }, + { + test: /\.css$/, + use: [ + isDebug + ? { + loader: "style-loader", + options: { + injectType: "singletonStyleTag" + } + } + : MiniCssExtractPlugin.loader, + { + loader: "css-loader", + options: { + modules: false, + importLoaders: 1, + sourceMap: isDebug + } + }, + { + loader: "postcss-loader", + options: postCssConfig + } + ] + }, { test: /\.scss$/, use: [ @@ -132,7 +157,7 @@ const serverConfig = merge(commonConfig, voltranServerConfig, { new MiniCssExtractPlugin({ filename: '[name].css', - chunkFilename: '[id].css', + chunkFilename: "[id]-[contenthash].css" }), ...(isDebug ? [new webpack.HotModuleReplacementPlugin()] : [])