Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbortSignal needs a COMPLETE #52

Open
henryruhs opened this issue Jun 5, 2023 · 0 comments
Open

AbortSignal needs a COMPLETE #52

henryruhs opened this issue Jun 5, 2023 · 0 comments

Comments

@henryruhs
Copy link
Owner

henryruhs commented Jun 5, 2023 •
edited
Loading

The AbortSignal has to be extended by COMPLETED as the Observable stays open until timeout kicks in and ABORTED is thrown. Interceptor therefore needs this:

takeUntil(this.abortService.get(request).pipe(filter(signal => signal === 'ABORTED' || signal === 'COMPLETED')))
@henryruhs henryruhs changed the title Abort feature needs a COMPLETE AbortSignal needs a COMPLETE Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henryruhs