From ea0f77f8576b3070d64031a3ed779daaca5a04a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20D=C3=B6ge?= <67548904+msdoege@users.noreply.github.com> Date: Wed, 19 May 2021 17:16:50 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Markus Wieczorek <16155269+maggusw@users.noreply.github.com> --- Healex.HL7v2Anonymizer.Tests/AnonymizerTests.cs | 2 +- Healex.HL7v2Anonymizer/Services/Anonymizer.cs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Healex.HL7v2Anonymizer.Tests/AnonymizerTests.cs b/Healex.HL7v2Anonymizer.Tests/AnonymizerTests.cs index ce48187..dc9517c 100644 --- a/Healex.HL7v2Anonymizer.Tests/AnonymizerTests.cs +++ b/Healex.HL7v2Anonymizer.Tests/AnonymizerTests.cs @@ -45,7 +45,7 @@ public void AnonymizerTestAdtSegmentOrderWithAnonymization() // Assert Assert.IsTrue(originalMessage.SegmentCount == message.SegmentCount); - for (int i = 0; i < originalMessage.SegmentCount; i++) + for (var i = 0; i < originalMessage.SegmentCount; i++) { var originalSegment = originalMessage.Segments().ElementAt(i); var messageSegment = message.Segments().ElementAt(i); diff --git a/Healex.HL7v2Anonymizer/Services/Anonymizer.cs b/Healex.HL7v2Anonymizer/Services/Anonymizer.cs index 6c06a65..854cc34 100644 --- a/Healex.HL7v2Anonymizer/Services/Anonymizer.cs +++ b/Healex.HL7v2Anonymizer/Services/Anonymizer.cs @@ -18,11 +18,11 @@ public bool Anonymize(Message message) { var isSuccess = true; - for (int segmentIndex = 0; segmentIndex < message.SegmentCount; segmentIndex++) + for (var segmentIndex = 0; segmentIndex < message.SegmentCount; segmentIndex++) { var segment = message.Segments().ElementAt(segmentIndex); if (_replacementOptions.Segments.FirstOrDefault(segRep => segRep.Segment == segment.Name) - is var segmentReplacement && segmentReplacement != null) + is { } segmentReplacement) { // Create new temporary message for each repeating segment // because we can't set values in all repeating segments at once @@ -43,7 +43,7 @@ private Message AddSegmentAtIndex(Segment segment, int segmentIndex) var tempMessage = new Message(); // workaround to ensure the segment gets it absolute (internal) SequenceNo re-assigned in AddNewSegment() - for (int i = 0; i < segmentIndex; i++) + for (var i = 0; i < segmentIndex; i++) { tempMessage.AddNewSegment(new Segment("DummySegment", new HL7Encoding())); }