frontend: Refactor prepareSidebarItems into a hook #2717
Merged
+465
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sniok
force-pushed
the
refactor-and-fix-prepare-routes
branch
from
037c00f to
c373a63
Compare
sniok
force-pushed
the
refactor-and-fix-prepare-routes
branch
from
c373a63 to
babd7eb
Compare
Signed-off-by: Oleksandr Dubenko <[email protected]>
sniok
force-pushed
the
refactor-and-fix-prepare-routes
branch
from
babd7eb to
fe03878
Compare
dosubot
bot
added
the
size:XL
illume
approved these changes
Feb 8, 2025
|
@sniok sorry, I noticed just now sidebar is crashing when pressing collapse/uncollapse sidebar button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2714
This hook will also support arbitrary depth for the sidebar
Testing done:
Added unit tests
Tested with different plugins to make sure the sidebar works