Skip to content

Commit

Permalink
Editor: Add shadow intensity support. (mrdoob#28597)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mugen87 authored Jun 10, 2024
1 parent e37cf82 commit 8eccd73
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
18 changes: 18 additions & 0 deletions editor/js/Sidebar.Object.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,17 @@ function SidebarObject( editor ) {

container.add( objectShadowRow );

// shadow intensity

const objectShadowIntensityRow = new UIRow();

objectShadowIntensityRow.add( new UIText( strings.getKey( 'sidebar/object/shadowIntensity' ) ).setClass( 'Label' ) );

const objectShadowIntensity = new UINumber( 0 ).setRange( 0, 1 ).onChange( update );
objectShadowIntensityRow.add( objectShadowIntensity );

container.add( objectShadowIntensityRow );

// shadow bias

const objectShadowBiasRow = new UIRow();
Expand Down Expand Up @@ -580,6 +591,12 @@ function SidebarObject( editor ) {

if ( object.shadow !== undefined ) {

if ( object.shadow.intensity !== objectShadowIntensity.getValue() ) {

editor.execute( new SetValueCommand( editor, object.shadow, 'intensity', objectShadowIntensity.getValue() ) );

}

if ( object.shadow.bias !== objectShadowBias.getValue() ) {

editor.execute( new SetValueCommand( editor, object.shadow, 'bias', objectShadowBias.getValue() ) );
Expand Down Expand Up @@ -846,6 +863,7 @@ function SidebarObject( editor ) {

if ( object.shadow !== undefined ) {

objectShadowIntensity.setValue( object.shadow.intensity );
objectShadowBias.setValue( object.shadow.bias );
objectShadowNormalBias.setValue( object.shadow.normalBias );
objectShadowRadius.setValue( object.shadow.radius );
Expand Down
4 changes: 4 additions & 0 deletions editor/js/Strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ function Strings( config ) {
'sidebar/object/penumbra': 'Penumbra',
'sidebar/object/decay': 'Decay',
'sidebar/object/shadow': 'Shadow',
'sidebar/object/shadowIntensity': 'Shadow Intensity',
'sidebar/object/shadowBias': 'Shadow Bias',
'sidebar/object/shadowNormalBias': 'Shadow Normal Bias',
'sidebar/object/shadowRadius': 'Shadow Radius',
Expand Down Expand Up @@ -543,6 +544,7 @@ function Strings( config ) {
'sidebar/object/penumbra': 'Pénombre',
'sidebar/object/decay': 'Affaiblissement',
'sidebar/object/shadow': 'Ombre',
'sidebar/object/shadowIntensity': 'Shadow Intensity',
'sidebar/object/shadowBias': 'Biais directionnel des ombres',
'sidebar/object/shadowNormalBias': 'Shadow Normal Bias',
'sidebar/object/shadowRadius': 'Rayon de l\'ombre',
Expand Down Expand Up @@ -943,6 +945,7 @@ function Strings( config ) {
'sidebar/object/penumbra': '边缘',
'sidebar/object/decay': '衰减',
'sidebar/object/shadow': '阴影',
'sidebar/object/shadowIntensity': 'Shadow Intensity',
'sidebar/object/shadowBias': '阴影偏移',
'sidebar/object/shadowNormalBias': '阴影法线偏移',
'sidebar/object/shadowRadius': '阴影半径',
Expand Down Expand Up @@ -1343,6 +1346,7 @@ function Strings( config ) {
'sidebar/object/penumbra': '半影',
'sidebar/object/decay': '減衰',
'sidebar/object/shadow': '影',
'sidebar/object/shadowIntensity': 'Shadow Intensity',
'sidebar/object/shadowBias': '影のバイアス',
'sidebar/object/shadowNormalBias': '影のノーマルバイアス',
'sidebar/object/shadowRadius': '影の半径',
Expand Down

0 comments on commit 8eccd73

Please sign in to comment.