Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal-head prerelase date and commit are not updated #10537

Open
ulysses4ever opened this issue Nov 7, 2024 · 3 comments · Fixed by #10654 · May be fixed by #10756
Open

cabal-head prerelase date and commit are not updated #10537

ulysses4ever opened this issue Nov 7, 2024 · 3 comments · Fixed by #10654 · May be fixed by #10756
Labels
continuous-integration type: bug

Comments

@ulysses4ever
Copy link
Collaborator

Follow-up on #10515

The new release action doesn't update the date on the prerelease itself nor the commit it says was used to create the prerelease. It only updates the binaries and that's it...
photo_2024-11-07_11-20-44
(0d80d52 is from October 3rd.)

We probably should explicitly remove the old prerelease before calling the release action (e.g. via https://github.com/marketplace/actions/delete-a-release).
@ulysses4ever ulysses4ever mentioned this issue Nov 7, 2024
Closed
ulysses4ever added a commit to ulysses4ever/cabal that referenced this issue Nov 8, 2024
@ulysses4ever
CI: remove cabal-head before updating it (fix haskell#10537)
de17531
@ulysses4ever ulysses4ever mentioned this issue Nov 9, 2024
Closed
1 task
@ulysses4ever ulysses4ever mentioned this issue Dec 19, 2024
Closed
TeofilC pushed a commit that referenced this issue Dec 19, 2024
@ulysses4ever @TeofilC
CI: remove cabal-head before updating it (fix #10537)
b36aed8
@TeofilC TeofilC mentioned this issue Dec 19, 2024
Merged
1 task
TeofilC pushed a commit that referenced this issue Dec 19, 2024
@ulysses4ever @TeofilC
CI: remove cabal-head before updating it (fix #10537)
d4abdd7
TeofilC pushed a commit that referenced this issue Dec 19, 2024
@ulysses4ever @TeofilC
CI: remove cabal{,-lts}-head before updating it (fix #10537)
6918756
TeofilC pushed a commit that referenced this issue Dec 19, 2024
@ulysses4ever @TeofilC
CI: remove cabal{,-lts}-head before updating it (fix #10537)
85baf34
TeofilC pushed a commit that referenced this issue Dec 19, 2024
@ulysses4ever @TeofilC
CI: remove cabal{,-lts}-head before updating it (fix #10537)
3228435
@mergify mergify bot closed this as completed in #10654 Dec 19, 2024
@mergify mergify bot closed this as completed in 9949014 Dec 19, 2024
mergify bot added a commit that referenced this issue Dec 19, 2024
@mergify
Merge pull request #10654 from haskell/wip/T10652
fc186ef 
CI: remove cabal-head before updating it (fix #10537)
mergify bot pushed a commit that referenced this issue Dec 20, 2024
@ulysses4ever @mergify
CI: remove cabal{,-lts}-head before updating it (fix #10537)
7eff8c8 
(cherry picked from commit 9949014)

# Conflicts:
#	.github/workflows/validate.yml
@mergify mergify bot mentioned this issue Dec 20, 2024
Merged
1 task
geekosaur pushed a commit that referenced this issue Dec 20, 2024
@ulysses4ever @geekosaur
CI: remove cabal{,-lts}-head before updating it (fix #10537)
45449d1 
(cherry picked from commit 9949014)
mergify bot added a commit that referenced this issue Dec 21, 2024
@mergify @ulysses4ever @geekosaur
Backport #10654: CI: remove cabal-head before updating it (fix #10537) (
1d84640 
#10657)

* CI: remove cabal{,-lts}-head before updating it (fix #10537)

(cherry picked from commit 9949014)

* The release cleanup action requires a token

(cherry picked from commit ad266b1)

---------

Co-authored-by: Artem Pelenitsyn <[email protected]>
Co-authored-by: brandon s allbery kf8nh <[email protected]>
@ulysses4ever
Copy link
Collaborator Author

after several attempts at fixing it, it's still not right for some reason...

@ulysses4ever ulysses4ever reopened this Dec 24, 2024
@geekosaur
Copy link
Collaborator

https://github.com/marketplace/actions/nightly-release
https://github.com/marketplace/actions/github-release
https://github.com/actions/create-release
are some alternatives

@ulysses4ever
Copy link
Collaborator Author

Right, would be great to try it out. I don't think I'll have time for it any time soon though :-( /cc @TeofilC

TeofilC added a commit that referenced this issue Jan 17, 2025
@TeofilC
ci: update the existing nightly prerelease
9ea29ca 
Resolves #10537
This was referenced Jan 17, 2025
Merged
Open
TeofilC added a commit that referenced this issue Jan 20, 2025
@TeofilC
ci: properly update metadata on nigthly releases
81d47c9 
Previously only the artifacts would be replaced and all the other
information would stay the same as the original nightly release.

Resolves #10537
TeofilC added a commit that referenced this issue Jan 20, 2025
@TeofilC
ci: properly update metadata on nigthly releases
af23627 
Previously only the artifacts would be replaced and all the other
information would stay the same as the original nightly release.

Resolves #10537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration type: bug
Projects
None yet
Milestone
No milestone
2 participants
@geekosaur @ulysses4ever