Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated -fwarn- flags #10742

Closed
philderbeast opened this issue Jan 12, 2025 · 1 comment · Fixed by #10743
Closed

Stop using deprecated -fwarn- flags #10742

philderbeast opened this issue Jan 12, 2025 · 1 comment · Fixed by #10743

Comments

@philderbeast
Copy link
Collaborator

philderbeast commented Jan 12, 2025 •
edited
Loading

I see that ghc-8.0.1 was released "21 May 2016" from GHC status along with base-4.9.0.0. Can we bump the CPP guards forward to this point in time?
#if MIN_VERSION_base(4,9,0)

This would allow us to do things like switch from -fwarn-* and -fno-warn-* to -W* and -Wno-*.

In GHC < 8 the syntax for -W⟨wflag⟩ was -fwarn-⟨wflag⟩ (e.g. -fwarn-incomplete-patterns). This spelling is deprecated, but still accepted for backwards compatibility. Likewise, -Wno-⟨wflag⟩ used to be fno-warn-⟨wflag⟩ (e.g. -fno-warn-incomplete-patterns).

SOURCE: GHC Users Guide - Warnings and sanity-checking.

Originally posted by @philderbeast in #8998 (comment)
@philderbeast philderbeast mentioned this issue Jan 12, 2025
Merged
2 tasks
@ulysses4ever
Copy link
Collaborator

GHC 8.0 is out of our support window. So, in principle, yes. But, as recently noticed by our users, we are not explicit enough about dropping support for certain GHCs. Even if this is implied by our GHC support policy, it should be announced (in the release announcement, perhaps).

@mergify mergify bot closed this as completed in #10743 Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use newer warning flags cabalism/cabal
2 participants
@philderbeast @ulysses4ever