Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrometheusExporter in instrumentation guide is undefined #12

Open
ndarilek opened this issue Dec 17, 2019 · 4 comments
Open

PrometheusExporter in instrumentation guide is undefined #12

ndarilek opened this issue Dec 17, 2019 · 4 comments

Comments

@ndarilek
Copy link

Hey, thanks for this. I attempted to use your guide for Prometheus instrumentation, but I don't see PrometheusExporter defined anywhere. I.e.:

alias MyApp.{
  PhoenixInstrumenter,
  PipelineInstrumenter,
  PrometheusExporter,
  RepoInstrumenter,
  VersionInstrumenter
}

And yes, I did replace MyApp. :)

Thanks.

@happysalada
Copy link
Owner

I need to update this guide, it's quite old. Since telemetry appeared, there are different ways of doing things.
In the meanwhile you have to check out the individual repos for prometheus integration and follow the installation there
https://github.com/deadtrickster/prometheus-ecto
(for Ecto. then there is a phoenix one)

I'm in the process of updating docs, but I'm afraid it will take a little bit of time

@happysalada
Copy link
Owner

actually I forgot to include the installation steps here
https://github.com/deadtrickster/prometheus.ex
If you replace ExampleInstrumenter by PrometheusInstrumenter on their instruction, you should be good to go

@ndarilek
Copy link
Author

ndarilek commented Dec 19, 2019 via email

@ndarilek
Copy link
Author

ndarilek commented Dec 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants