Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime of time range upper limit to include the whole day #3

Closed
souliane opened this issue Mar 9, 2022 · 2 comments
Closed

Comments

@souliane
Copy link

souliane commented Mar 9, 2022

If I type timew bal 2022-01-01 to 2022-03-09 or timew bal 2022-01-01 to today (today is 2022-03-09), it actually doesn't count 2022-03-09 and calculate the balance only until yesterday. I think that's a bug, instead of getting this:

Start: Sat Jan  1 00:00:00 2022
  End: Wed Mar  9 00:00:00 2022

I expect to get this:

Start: Sat Jan  1 00:00:00 2022
  End: Thu Mar 10 00:00:00 2022

or, if you prefer, this would also be OK:

Start: Sat Jan  1 00:00:00 2022
  End: Wed Mar  9 23:59:59 2022
@guludo
Copy link
Owner

guludo commented May 14, 2022

Hi @souliane.

Thank you for your feedback!

Yes. I think the original behavior was a bit confusing and that kinda bothered me too. I just applied a set of patches that changes the default behavior so that the start datetime is rounded down and the end datetime is rounded up.

I'll keep this issue open so you can confirm if that solves this.

@guludo guludo reopened this May 14, 2022
@souliane
Copy link
Author

Works fine, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants