From 8719780c5a1ea7d7b99da149132150dc56052b9b Mon Sep 17 00:00:00 2001 From: Rachel Evans Date: Tue, 13 Feb 2024 08:45:05 +0100 Subject: [PATCH] Send all invalid mentions output to stderr --- lib/kennel/tasks.rb | 4 ++-- test/kennel/tasks_test.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/kennel/tasks.rb b/lib/kennel/tasks.rb index 47408118..4df5563d 100644 --- a/lib/kennel/tasks.rb +++ b/lib/kennel/tasks.rb @@ -91,8 +91,8 @@ def git_push? if bad.any? url = Kennel::Utils.path_to_url "/account/settings" - Kennel.out.puts "Invalid mentions found, either ignore them by adding to `KNOWN` env var or add them via #{url}" - bad.each { |f, v| Kennel.out.puts "Invalid mention #{v} in monitor message of #{f}" } + Kennel.err.puts "Invalid mentions found, either ignore them by adding to `KNOWN` env var or add them via #{url}" + bad.each { |f, v| Kennel.err.puts "Invalid mention #{v} in monitor message of #{f}" } Kennel::Tasks.abort ENV["KNOWN_WARNING"] end end diff --git a/test/kennel/tasks_test.rb b/test/kennel/tasks_test.rb index d35ab725..45278a4b 100644 --- a/test/kennel/tasks_test.rb +++ b/test/kennel/tasks_test.rb @@ -303,7 +303,7 @@ def execute(...) it "fails when unknown mentions are used" do content[:message] = "@oo@ps" assert_raises { execute }.message.must_equal "Aborted SystemExit" - stdout.string.must_include "Invalid mentions" + stderr.string.must_include "Invalid mentions" end end