-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch naming validation #64
Comments
Oh wow thanks that's humbling, really! Regarding the branch naming validation, when should it be performed? On creation, before push, something else? Maybe it should be configurable? |
I think, before push is the right one. Because if it's incorrect, you can easily change the name with git checkout -b new-branch-name |
I think it would be better to check on creation |
Or Anyway, both things can be done, and we can let the user choose on what event they want the check to happen, maybe? |
@greg0ire yes. I just don't want to over engeneer |
Here is how it's done for git_template/template/hooks/make/pre-push Lines 6 to 8 in 820f947
git_template/template/hooks/make/pre-commit Lines 6 to 8 in 820f947
|
I'm in love at first sight with this repo ❤️
My idea is to validate branch name against some pattern
so for example,
as I personally mostly use git flow.
Plus I want to see ticket number as a part of the branch
so I write this regex
which will match this one
The text was updated successfully, but these errors were encountered: