From 04fe3a3e15f977597aecedcef801c881458e90cb Mon Sep 17 00:00:00 2001
From: Nathan Farmer <nathan@greatexpectations.io>
Date: Fri, 8 Mar 2024 10:41:49 -0500
Subject: [PATCH] Fix bug in test input validation

---
 src/antd/InputNumber.tsx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/antd/InputNumber.tsx b/src/antd/InputNumber.tsx
index 830239c..cebd2e9 100644
--- a/src/antd/InputNumber.tsx
+++ b/src/antd/InputNumber.tsx
@@ -52,7 +52,8 @@ export const InputNumber = (props: InputNumberProps): InputNumber => {
     return ""
   })
   const parser = ((value?: string): number => {
-    if (value !== "" && value !== undefined) {
+    const isNumeric = value ? !isNaN(Number(value)) : false
+    if (isNumeric && value !== undefined) {
       if (isPercentage) {
         return parseFloat(value.replace("%", "")) / 100.0
       } else {
@@ -60,8 +61,8 @@ export const InputNumber = (props: InputNumberProps): InputNumber => {
       }
     }
     // this allows us to return undefined for cases where the value has been deleted
-    // when InputNumber is paired with a Slider, the Slider pointer will disappear
-    // insetad of jumping to some default value
+    // when InputNumber is paired with a Slider, the Slider value selector will disappear
+    // for required fields an error message will show instead of jumping to some default value
     return undefined as unknown as number
   })