Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade web ui dependencies #50687

Open
avatus opened this issue Jan 2, 2025 · 0 comments
Open

Upgrade web ui dependencies #50687

avatus opened this issue Jan 2, 2025 · 0 comments
Labels
dependencies Pull requests that update a dependency file feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@avatus
Copy link
Contributor

avatus commented Jan 2, 2025

A couple of web UI dependencies keep popping up every dependabot update that would require a bit more work than "poke around and maybe fix some new type error". We'd need to schedule some time to get these handled. This will be a living list that we can tackle separately or when it grows to a length that we think could fit into a "meta goal" for a quarter.

  1. react-day-picker. see comment
    this probably could be tackled pretty quickly but requires a bit of extensive testing to ensure the styles are kept the same (or agreed upon an upgrade) around the app.

  2. react-router (and react-router-dom) see comment
    not only does react router usually make breaking changes in their major version updates (makes sense) but they seem to upgrade major versions quite frequently. There are a few things that are VERY abundant in our code base (the way we use query params in our templates) that prevented us from upgrading to 6 and now they are on 7. This could be quite a large refactor but should probably be done at some point to keep us up to date.

@avatus avatus added dependencies Pull requests that update a dependency file feature-request Used for new features in Teleport, improvements to current should be #enhancements labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

No branches or pull requests

1 participant