Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] Shopify GraphiQL App: Lost all my tabs with the queries #3494

Closed
1 task done
Cyclodex opened this issue Jan 11, 2024 · 12 comments
Closed
1 task done

[graphiql] Shopify GraphiQL App: Lost all my tabs with the queries #3494

Cyclodex opened this issue Jan 11, 2024 · 12 comments

Comments

@Cyclodex
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Logged into shopify, opening the GraphiQL App, no tabs are there anymore

Expected Behavior

Logged into shopify, opening the GraphiQL App, all my tabs are there. I had like around 10 tabs with queries

Steps To Reproduce

  1. Login shopify
  2. Open GraphiQL
  3. None of my tabs appear

Environment

  • GraphiQL Version: latest ?
  • OS: -
  • Browser: Chrome 120
  • Bundler: -
  • react Version: -
  • graphql Version: -

Anything else?

I am wondering who is responsible for the tabs, as it is from the Shopify GraphiQL App, the responsibility might be on shopify side, not sure so.

Anyone else having the same issue?
Maybe its related to the latest update, before I could log in, I had to accept an update of the application?

Any possibility to restore my lost tabs?

Thanks for any hints.

@Cyclodex Cyclodex changed the title [graphiql] Shopify integrated: Lost all my tabs with the queries [graphiql] Shopify GraphiQL App: Lost all my tabs with the queries Jan 11, 2024
@acao
Copy link
Member

acao commented Jan 11, 2024

@Cyclodex do you have the tabs storied in your local storage?

@acao
Copy link
Member

acao commented Jan 11, 2024

did spotify disable tabs?

#3408

@Cyclodex
Copy link
Author

@Cyclodex do you have the tabs storied in your local storage?

No idea... Can you cofigure that somewhere?
If localstorage... Then i would not know why or how, but then it could have been deleted by mistake?!
But that would be strange, as its a separate domain.

Could it be, that a app update messed up something, maybe cleaning the storage? Re initialized or something like that?

If no one else is affected, then dont worry, i will recreate the queries... But still bit sad

@Cyclodex
Copy link
Author

PS: i can have tabs, just all my old ones are gone somehow

@Cyclodex
Copy link
Author

Cyclodex commented Jan 12, 2024

Okey - interesting. I just lost the tabs again, I had at least 2 tabs yesterday.

Now looking at the storage, it looks like the tabs and queries are saved in the local storage key graphiql:tabstate right?
Does that get overriden somehow? I will monitor the situation a bit, I added 2 tabs again and currently it looks like this:

image

@acao
Copy link
Member

acao commented Jan 12, 2024

it shouldn't have been overridden... this is very strange! if you can find a repo for shopify's graphiql implementation, or have a support person reach out to me here in this issue discussion we can work on it together. it may be that a recent release caused a bug, the release allows disabling tabs, but I can't see anything that would cause this issue if they aren't using this new option

it's likely that they were pinned to an older version, and upgraded some things, and some config that they upgraded caused this issue

another question - does your query history still show the old queries? because if not, then it's an issue regarding localstorage and the namespace then

@Cyclodex
Copy link
Author

Nope, basically empty history , but honestly I never checked the history until now! Only the few entries I did today so it looks.

Yes maybe something changed with namespaces or similar. I just try to reach out to shopify support, maybe they can tell me where I should place the request.

@Cyclodex
Copy link
Author

Okey, they want me to monitor the situation and report if it happens again. I gave them all information I had at hand...

To note it here as well:
I am sure I had the tabs on 1.12.2023 (1.st December).
Yesterday I had no tabs anymore - Created again 2 tabs
This morning they were gone again. Currently I have around 6 tabs.

Lets see if something is happening in the upcoming hours/days :/

@acao
Copy link
Member

acao commented Jan 13, 2024

here for example, if I add new tabs and refresh, they are still there. not sure what would make the tabs disappear unless they have a custom storage implementation. without knowing the details of shopify's implementation, there isn't much I can do to help you, sorry!

@Cyclodex
Copy link
Author

Nothing happend yet to my tabs, all seems to be stable now

@acao
Copy link
Member

acao commented Jan 16, 2024

i notice entries for two seperate domains, perhaps shopify changed the domain of the graphiql instance which would lead to this?

another possibility is that localstorage eventually expires. it's persistence is not guaranteed in all browsers like indexeddb or webcache. browsers often have storage limits and sometimes the localstorage cache will be evicted for some sites. localstorage tends to last much longer in installable PWAs though!

@Cyclodex
Copy link
Author

Hi @acao , I also think it could be related to localstorage get cleaned up somehow. Tabs are still there, I will close the issue, as no one else has reported issues as well. Thanks anyway for your help and cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants