Should tanka deploy test charts by default?

[gassiss]

Hi team!

It seems like when I run tk apply it automatically deploys test charts as well. Is that intended behaviour? I feel like it should only run tests if we explicitly tell it to.

I put together a small repo reproducing this: https://github.com/gassiss/tanka-issue-example

[Duologic]

How does Helm handle this? Tanka simply renders the chart with helm template, this output can be modified in jsonnet.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[lkiii]

local excludeChartTests(resources) =
  {
    [item.key]: item.value
    for item in std.objectKeysValues(resources)
    if !(std.type(item.value) == 'object' &&
       std.objectHas(item.value, 'metadata') &&
       std.objectHas(item.value.metadata, 'annotations') &&
       std.objectHas(item.value.metadata.annotations, 'helm.sh/hook') &&
       item.value.metadata.annotations['helm.sh/hook'] == 'test')
  };

I was having the same issue and this looks like something universal which could help in this case

[zerok]

helm template also has a --skip-tests flag. Perhaps it's just enough that we use that flag when running helm template ?

[lkiii]

Yeah that would make most senses, this could be additional optional flag passed for helm.template() so this would still be backwards compatible

https://github.com/grafana/tanka/blob/main/pkg/helm/helm.go#L25 maybe there is a way to pass it via opts already?

Edit: I believe it is https://github.com/grafana/tanka/blob/main/pkg/helm/template.go#L98

[zerok]

Jupp, just stumbled upon it at the same time :D Perhaps I can come up with a simple sample tomorrow (if it works) :)

[zerok]

Using the skipTests property when calling helm.template in your wrapper code should work (at least it passes the right arguments):

helm.template('nginx', './charts/nginx-ingress', {
  skipTests: true,
  // values: { ... }
}),

[lkiii]

Yep it works well with the flag on my end as well. https://stackoverflow.com/a/79346465/816230 I have posted the example here

[strowi]

Can confirm, @zerok 's skiptests: true works (not case-sensitive).
Had to search through github issues to the MR, this probably could be better documented on tanka.dev ;)

[zerok]

@strowi #1329 first try 🤣