Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: go through browser code and reduce forbidigo exceptions #4094

Open
mstoykov opened this issue Dec 10, 2024 · 0 comments
Open

browser: go through browser code and reduce forbidigo exceptions #4094

mstoykov opened this issue Dec 10, 2024 · 0 comments

Comments

@mstoykov
Copy link
Contributor

After grafana/xk6-browser#1557 there are quite a few foribidgo nolints in the browser code base. And after #4056 is merged those will be part of k6 directly which is why this is opened here.

Most of those likely should just use fsext.

Some of those are logger related, whcih likely needs to jsut be removed outright and use the k6 logger to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant