Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasketches support (quantilesDoubleSketch) #94

Open
jln-pl opened this issue Jun 14, 2021 · 8 comments
Open

Datasketches support (quantilesDoubleSketch) #94

jln-pl opened this issue Jun 14, 2021 · 8 comments

Comments

@jln-pl
Copy link

jln-pl commented Jun 14, 2021

Hi!
I see that you have a druid-datasketches extension.

Are you going to add aggregator and post aggregators for quantilesDoubleSketch?

@jbguerraz
Copy link
Contributor

jbguerraz commented Jun 17, 2021

Hello @jln-pl
Thank you for this issue!
We would be happy to support that extension, first of all it would need support on the go-druid side of the plugin, mostly like what was done for tdigest sketch (see grafadruid/go-druid@533761d) and then we would need to add the components in this plugin.
my team and I won't have time (and need) for such extension support in a short to mid term, but I'd be happy to help you contribute that feature! that would be awesome! it requires only minimal coding skills, no rocket science and maybe few hours of effort :) WDYT ?

@jln-pl
Copy link
Author

jln-pl commented Jun 24, 2021

I will try to do it in my spare time ;)

@jbguerraz
Copy link
Contributor

I'll be happy to help @jln-pl ! feel free to ping me on Slack for support :)

@san-san
Copy link
Contributor

san-san commented Feb 14, 2022

With grafadruid/go-druid#60 merged, Am I correct in saying that we only need changes in the plugin components to support quantilesDoubleSketch?

@jbguerraz
Copy link
Contributor

@san-san Yes, we need to add an aggregator component (https://github.com/grafadruid/druid-grafana/tree/master/src/builder/aggregation) and a post aggregation (https://github.com/grafadruid/druid-grafana/tree/master/src/builder/postaggregation) one.

@san-san
Copy link
Contributor

san-san commented Feb 17, 2022

Quick update, I have a working solution that we're testing now. We'll raise a PR shortly. https://github.com/san-san/druid-grafana/releases/tag/v1.3.0_beta if you'd like to try it out.

Note: quantilesDoublesSketchToQuantiles (https://druid.apache.org/docs/latest/development/extensions-core/datasketches-quantiles.html#quantiles) has not been implemented in go-druid.

Once my current change has been accepted and merged I can work on that.

@jbguerraz
Copy link
Contributor

Hello @san-san
Any chance you moved ahead with it ? need some support ?

@jbguerraz
Copy link
Contributor

just in case @san-san if you forgot this but actually made some progress :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants