Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate the feature generator between dyninstfeaturegenerator.cpp and flowgraphwithinstructions.cpp #7

Open
thomasdullien opened this issue Sep 20, 2018 · 0 comments

Comments

@thomasdullien
Copy link
Contributor

There's a comment about de-duplicating this code in dyininstfeaturegenerator; the current duplication of the code makes it very brittle.

The performance cost of forcing the dyninstfeaturegenerator to construct a Flowgraphwithinstructions instance is nontrivial, but code duplication is evil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant