Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub token isn't exposed on forked pull requests #9

Closed
jirfag opened this issue May 7, 2020 · 3 comments
Closed

GitHub token isn't exposed on forked pull requests #9

jirfag opened this issue May 7, 2020 · 3 comments

Comments

@jirfag
Copy link
Contributor

jirfag commented May 7, 2020

See golangci/golangci-lint#1072.

The issue is that secrets are not passed to workflows that are triggered by a pull request from a fork.

Currently this action uses github token to find the latest patch version of specified minor release.

My idea is to generate version-maps.json in golangci-lint repository and download it for detecting a last patch version. Using GitHub API without tokens can fail because of 60 req/hour rate limit.

@ernado
Copy link
Member

ernado commented May 7, 2020

jirfag added a commit that referenced this issue May 7, 2020
jirfag added a commit that referenced this issue May 7, 2020
@jirfag jirfag closed this as completed in fc9d172 May 7, 2020
@jirfag
Copy link
Contributor Author

jirfag commented May 7, 2020

looks like it works, thank you @ernado !

@jirfag
Copy link
Contributor Author

jirfag commented May 7, 2020

and we can get rid of it as a simplifying feature in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants