Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Enhance accordion header interactions for better UX #12813

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

GirlBossRush
Copy link
Contributor

  • Allows user to click or tap anywhere on a accordion header to expand or collapse.
  • Adds transition to collapse.

Details

While working with the accordions, I saw an opportunity to improve their navigation. This PR expands the clickable area to the full header and adds a smooth transition animation - small refinements that should make the interface more fluid and intuitive.

Appreciate the team taking a look at this ease-of-use enhancement!

Technical changes:

  • Extended click target to full header width
  • Added collapse transition animation
  • Maintained existing accessibility attributes

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush requested a review from a team as a code owner January 25, 2025 09:21
Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 5b64480
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67ae3973f25a2900083b1b2e

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 5b64480
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67ae397329829a0008d79699
😎 Deploy Preview https://deploy-preview-12813--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (5904fae) to head (5b64480).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12813      +/-   ##
==========================================
+ Coverage   92.68%   92.75%   +0.07%     
==========================================
  Files         785      785              
  Lines       39623    39623              
==========================================
+ Hits        36724    36752      +28     
+ Misses       2899     2871      -28     
Flag Coverage Δ
e2e 48.48% <ø> (+0.70%) ⬆️
integration 24.54% <ø> (-0.01%) ⬇️
unit 90.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions to Teffen, but this looks like a fair implementation, so I'm not going to quibble.

- Allows user to click or tap anywhere on a accordion header to expand
  or collapse.
- Adds transition to collapse.
@GirlBossRush GirlBossRush force-pushed the accordion-header-fixes branch from cc69840 to 5b64480 Compare February 13, 2025 18:26
@GirlBossRush GirlBossRush merged commit 49cc70e into goauthentik:main Feb 14, 2025
69 checks passed
@GirlBossRush GirlBossRush deleted the accordion-header-fixes branch February 14, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants