Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3/glfw: Annotate functions with #cgo noescape/nocallback where possible #407

Open
Jacalz opened this issue Feb 5, 2025 · 2 comments
Open

Comments

@Jacalz
Copy link
Collaborator

Jacalz commented Feb 5, 2025

Go 1.24 is supposed to be releasing any day now and it includes support for new two new annotations #cgo noescape and #cgo nocallback (see https://tip.golang.org/doc/go1.24#cgo).

I'm not sure to which degree these are relevant for us but if they are, then we should likely be able to squeeze a but more performance out of the package.

@dmitshur
Copy link
Member

dmitshur commented Feb 5, 2025

Yeah, it’s interesting how much that can help here. We’ll need some measurements to evaluate and decide.

Somewhat separately, it’d be good if we can help land v3.4, and target such enhancements there instead of the older v3.3.

@Jacalz
Copy link
Collaborator Author

Jacalz commented Feb 6, 2025

Indeed, yeah. Depending on when v3.4 is readily available here, we might want to try it out in v3.3 first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants