Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release script should switch to bash syntax completely #748

Closed
jdemel opened this issue Jan 30, 2024 · 3 comments · Fixed by #751
Closed

release script should switch to bash syntax completely #748

jdemel opened this issue Jan 30, 2024 · 3 comments · Fixed by #751
Labels
bug

Comments

@jdemel
Copy link
Contributor

jdemel commented Jan 30, 2024

The release script should always run in ZSH. However:

5b23afd

i.e. it runs in bash at the moment and produced a borked release.
@argilo
Copy link
Member

argilo commented Jan 30, 2024

My suggestion would be to change line 9 to set -e and then fix any errors that come up when running the script.

@argilo argilo added the bug label Jan 30, 2024
@jdemel
Copy link
Contributor Author

jdemel commented Jan 30, 2024

My suggestion would be to change line 9 to set -e and then fix any errors that come up when running the script.

Actually, I prefer that too.

@jdemel jdemel changed the title release script is meant to run in zsh release script should switch to bash syntax completely Jan 30, 2024
@argilo argilo mentioned this issue Jan 30, 2024
Closed
@ZeroChaos-
Copy link
Contributor

I tried to give this a quick pass since this is something I'm decent at.

#751

@ZeroChaos- ZeroChaos- mentioned this issue Jan 30, 2024
Merged
ZeroChaos- added a commit to ZeroChaos-/volk that referenced this issue Jan 30, 2024
@ZeroChaos-
shellcheck fixes
08da5ae 
Closes: gnuradio#748
Signed-off-by: Zero_Chaos <[email protected]>
ZeroChaos- added a commit to ZeroChaos-/volk that referenced this issue Jan 30, 2024
@ZeroChaos-
shellcheck fixes
95d99da 
Closes: gnuradio#748
Signed-off-by: Zero Chaos <[email protected]>
Signed-off-by: Rick Farina (Zero_Chaos) <[email protected]>
ZeroChaos- added a commit to ZeroChaos-/volk that referenced this issue Jan 30, 2024
@ZeroChaos-
shellcheck fixes
93c64e1 
Conditionalize use of signify-openbsd
Closes: gnuradio#748
Signed-off-by: Zero Chaos <[email protected]>

conditionalize both uses of signify

Signed-off-by: Zero Chaos <[email protected]>
ZeroChaos- added a commit to ZeroChaos-/volk that referenced this issue Jan 30, 2024
@ZeroChaos-
shellcheck fixes
9298be8 
Conditionalize use of signify-openbsd
Closes: gnuradio#748
Signed-off-by: Zero Chaos <[email protected]>
ZeroChaos- added a commit to ZeroChaos-/volk that referenced this issue Jan 30, 2024
@ZeroChaos-
shellcheck fixes
58c784b 
Conditionalize use of signify-openbsd
Closes: gnuradio#748
Signed-off-by: Rick Farina (Zero_Chaos) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release script improvements ZeroChaos-/volk
3 participants
@argilo @ZeroChaos- @jdemel