Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tip_reminder_mail_template recipets instead {LoginUrl} the recepients get the TOR URL #4377

Open
elbill opened this issue Jan 15, 2025 · 9 comments

Comments

@elbill
Copy link

elbill commented Jan 15, 2025

What version of GlobaLeaks are you using?

5.0.37

What browser(s) are you seeing the problem on?

Chrome

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

In tip_reminder_mail_template instead of {LoginUrl} the recepients get the TOR URL. This could be related to issue #2751

Dear xxx xxx, This is an email to notify you that the reminder date for one or more reports has been met. http://kv22nglpuef3jqyl44qqgjzxxxxxxxxx.onion/#/login Kind regards,

Proposed solution

When https is allowed then the https URL should show

@evilaliv3
Copy link
Member

Thank you @elbill

Typically the address vary depending on the configuration of the domain name.

  1. Does this platform have a domain name assigned?
  2. May i see the configuration of the template that you have for tip_reminder_mail_template?

@elbill
Copy link
Author

elbill commented Jan 15, 2025

  1. It does have a URL
    The platform is on the main tenant

This is an email to notify you that the reminder date for one or more reports has been met.

{LoginUrl}

Kind regards,
{NodeName}

@elbill
Copy link
Author

elbill commented Jan 15, 2025

Made a test and put the {LoginUrl} in admin test SMTP template and worked fine. Users however have this issue

@evilaliv3
Copy link
Member

Thank you @elbill

Actually I checked the code and it seems to me that the links varies only in relation to the presence of not of a configured hostname.

In the past did your users receive the correct link?

@elbill
Copy link
Author

elbill commented Jan 17, 2025 via email

@elbill
Copy link
Author

elbill commented Jan 28, 2025

It is very strange that despite I edited the message to provide not the {LoginUrl} but the direct link in the notification template, it still apears as an onion link. Is there a chance that the specific template is hardwired in the system and ignors the template?

@evilaliv3
Copy link
Member

No actually there is no hardcoding. If you put the link directly and you get an other result it means you are editing the wrong template.

If your system is single tenant check to be editing the correct template; if your system is multi tenant check the template included in the tenant

@elbill
Copy link
Author

elbill commented Jan 30, 2025

It is the same template (unless I do or see something very wrong). I attach the modified templates in both languages, the template and the email users receive. It is a singe main tenant, and the onion lint matches this. I had two test tenants , I deleted them just in case.

Image

Image

Image

@evilaliv3
Copy link
Member

I seem this is very strange to me. If you like tomorrow we could go through this with a screensharing session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants