Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of country from IP addresses of anonymous editors #11

Open
glimmerphoenix opened this issue Aug 13, 2014 · 0 comments
Open

Detection of country from IP addresses of anonymous editors #11

glimmerphoenix opened this issue Aug 13, 2014 · 0 comments
Assignees

Comments

@glimmerphoenix
Copy link
Owner

This enhancement started with pull-request by c-martinez SHA: acfd9e7

This new feature uses a VARCHAR field to store the IP addresses of anonymous editors in the DB schema. This may be quite inefficient for querying and indexing on this field.

An alternative solution would be using INET_ATON and INET_NTOA, either from MySQL (may raise compatibility issues with other DB backends) or from the Python code (more likely).

In addition, once the new DB API based on SQLAlchemy is ready, we will have support for PostgreSQL, which has its own data types and functions to handle IP addresses:

http://www.postgresql.org/docs/7.4/static/functions-net.html

Therefore, the improved solution must explore transparent support for different DB backends, as well as efficiency (to the extent possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant