From 1ca44b1427e74fe2e030efa45d1cb70bf1822ac8 Mon Sep 17 00:00:00 2001
From: Christian Weichel <chris@gitpod.io>
Date: Fri, 24 May 2024 09:24:44 +0000
Subject: [PATCH] Fix package links in HTML report

---
 pkg/leeway/reporter.go | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/pkg/leeway/reporter.go b/pkg/leeway/reporter.go
index af54bf3..a990491 100644
--- a/pkg/leeway/reporter.go
+++ b/pkg/leeway/reporter.go
@@ -278,6 +278,7 @@ func (r *WerftReporter) PackageBuildFinished(pkg *Package, rep *PackageBuildRepo
 }
 
 type HTMLPackageReport struct {
+	ID       string
 	logs     strings.Builder
 	start    time.Time
 	duration time.Duration
@@ -363,7 +364,10 @@ func (r *HTMLReporter) getReport(pkg *Package) *HTMLPackageReport {
 			return rep
 		}
 
-		rep = &HTMLPackageReport{status: PackageNotBuiltYet}
+		rep = &HTMLPackageReport{
+			ID:     pkg.FilesystemSafeName(),
+			status: PackageNotBuiltYet,
+		}
 		r.reports[name] = rep
 		r.mu.Unlock()
 	}
@@ -425,14 +429,14 @@ func (r *HTMLReporter) Report() {
 			<td>{{ $report.StatusIcon }}</td>
 			<td>{{ $pkg }}</td>
 			<td>{{ $report.DurationInSeconds -}}</td>
-			<td><a href="#{{ $pkg }}">See below</td>
+			<td><a href="#{{ $report.ID }}">See below</td>
 		</tr>
 		{{- end }}
 	</tbody>
 <table>
-<p>For details around each package, see below<p>
+<p>For details about each package, see below<p>
 {{- range $pkg, $report := .Packages }}
-<h2 id="{{ $pkg }}">{{ $pkg }}</h2>
+<h2 id="{{ $report.ID }}">{{ $report.StatusIcon }} {{ $pkg }}</h2>
 {{ if $report.HasError -}}
 <details open> 
 	<summary>Error message</summary>