Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add documentation for monitoring Gin with OpenTelemetry #4107

Closed
123liuziming opened this issue Nov 28, 2024 · 10 comments
Closed

Comments

@123liuziming
Copy link

Hi all, As we all know gin is the best http framework in the golang ecosystem. But I found that gin doesn't have the ability to integrate tracing and metrics by default and there doesn't seem to be a best practice in the documentation on how to monitor gin applications. Our project(https://github.com/alibaba/opentelemetry-go-auto-instrumentation) allows tracing and metrics to be collected and reported on the gin app without making changes to user code. I was wondering if it would be possible for me to add an observable subsection to the official documentation for this project that describes best practices for observing the gin application. Thanks!

@FarmerChillax
Copy link
Contributor

FarmerChillax commented Dec 1, 2024

I hope the observable part of the document will focus on the otel project, supplemented by the alibaba project.
(Rather than introducing Alibaba's tools in full length) :p

@123liuziming
Copy link
Author

supplemented

I agree, the project will be donated into OpenTelemetry Community soon, see open-telemetry/community#1961. We will focus on the otel project.

@damemi
Copy link

damemi commented Dec 27, 2024

We could also mention the OpenTelemetry eBPF based auto-instrumentation (https://github.com/open-telemetry/opentelemetry-go-instrumentation/), which supports Gin as well.

@123liuziming
Copy link
Author

123liuziming commented Jan 7, 2025

We could also mention the OpenTelemetry eBPF based auto-instrumentation (https://github.com/open-telemetry/opentelemetry-go-instrumentation/), which supports Gin as well.

Yes, I really want to raise a PR to introduce different ways of monitoring Gin Application based on OpenTelemetry EcoSystem!. @appleboy @thinkerou What do you think about that? cc @damemi

@123liuziming 123liuziming changed the title [Proposal] Monitor gin with https://github.com/alibaba/opentelemetry-go-auto-instrumentation [Proposal] Add documentation for monitoring Gin with OpenTelemetry Jan 7, 2025
@123liuziming
Copy link
Author

And can we also add a middleware for OpenTelemetry in https://github.com/gin-contrib?

@appleboy
Copy link
Member

appleboy commented Jan 7, 2025

@123liuziming Yes

And can we also add a middleware for OpenTelemetry in https://github.com/gin-contrib?

@123liuziming
Copy link
Author

@123liuziming Yes

And can we also add a middleware for OpenTelemetry in https://github.com/gin-contrib?

Cool!!! Should I raise a PR to modify https://github.com/gin-gonic/gin/blob/master/docs/doc.md or put the document into https://github.com/gin-contrib after you create the OpenTelemetry repository in it?

@appleboy
Copy link
Member

appleboy commented Jan 9, 2025

@123liuziming Thanks for your contribution. I closed the issue when PR was merged.

@appleboy appleboy closed this as completed Jan 9, 2025
@123liuziming
Copy link
Author

@appleboy Thanks, can we make the README refer to https://github.com/gin-gonic/contrib? PR here: #4134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants