Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving caches and versions file even if some frameworks fail to build #153

Open
ikesyo opened this issue Oct 24, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ikesyo
Copy link
Collaborator

ikesyo commented Oct 24, 2024

for target in targetsToBuild {
try await buildXCFrameworks(
target,
outputDir: outputDir,
buildOptionsMatrix: buildOptionsMatrix
)
}
if isProducingCacheEnabled {
await cacheSystem.cacheFrameworks(Set(targetsToBuild))
}
if shouldGenerateVersionFile {
// Versionfiles should be generate for all targets
for target in allTargets {
await generateVersionFile(for: target, using: cacheSystem)
}
}

Even if some frameworks fail to build, we can still save caches and version files for successfully-built frameworks. That would reduce build time for next attempts.

@ikesyo ikesyo changed the title Saving cache and version file even if some frameworks fail to build Saving caches and versions file even if some frameworks fail to build Oct 24, 2024
@mustafagunes
Copy link

Hi @ikesyo, I have been following and admiring your project for a while.

I have started using Scipio to reduce build times in the projects I am working on. I would like to contribute by solving this issue. Could you please assign it to me?

@ikesyo
Copy link
Collaborator Author

ikesyo commented Dec 17, 2024

Thanks for the comment! I just assigned you. 😃

@mustafagunes
Copy link

should I create the development branch from the main branch?

@ikesyo
Copy link
Collaborator Author

ikesyo commented Dec 19, 2024

Yes, please submit a pull request from a feature branch of your fork 🙏

@ikesyo ikesyo added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants