Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest the symfony/polyfill-mbstring package, but don't require it #674

Open
rimas-kudelis opened this issue Feb 27, 2025 · 1 comment
Open

suggest the symfony/polyfill-mbstring package, but don't require it #674

rimas-kudelis opened this issue Feb 27, 2025 · 1 comment

Comments

@rimas-kudelis
Copy link

Not sure if it's the right approach to require the polyfill. The user might already have the mbstring extension, in which case the polyfill is unnecessary, but making it required means it will be installed anyway.
@rimas-kudelis rimas-kudelis changed the title suggest the symfony/polyfill-mbstring package, not require it suggest the symfony/polyfill-mbstring package, but don't require it Feb 27, 2025
@rimas-kudelis
Copy link
Author

An example of what I'm proposing can be seen in PHPMailer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rimas-kudelis