Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Feedback: Restrict associated events to 30 minute recency #4681

Open
armcknight opened this issue Jan 7, 2025 · 1 comment
Open

User Feedback: Restrict associated events to 30 minute recency #4681

armcknight opened this issue Jan 7, 2025 · 1 comment

Comments

@armcknight
Copy link
Member

Description

Relay will reject feedback envelopes that contain an associated event id that occurred more than 30 minutes prior to the feedback's timestamp.

We don't yet have a crash report trigger for this, but will need to consider the delay between crash time and relaunch time to decide whether or not to pop the form dialog for it.

I can't think of any other scenarios we should consider here because associated IDs aren't currently linked in the feedback forms envelopes. Relay session IDs are linked at the time the submit button is hit so we're not in danger of grabbing a replay session ID and then letting it age out if the user leaves the feedback form open for more than 30 minutes.

@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Jan 7, 2025
@philipphofmann philipphofmann changed the title restrict associated events to 30 minute recency User Feedback: Restrict associated events to 30 minute recency Jan 8, 2025
@philipphofmann
Copy link
Member

Two ideas to fix this:

  1. Relay could accept such user feedback cause that's a valid use case on mobile.
  2. The SDK could modify the user feedback timestamp so it's close to the crash and doesn't exceed 30 minutes.

@philprime philprime moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants