Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Indexing Codebase - Handshake Failed #2035

Open
soumen02 opened this issue Sep 30, 2024 · 55 comments
Open

Error Indexing Codebase - Handshake Failed #2035

soumen02 opened this issue Sep 30, 2024 · 55 comments
Labels
bug Something isn't working dev needed This bug requires a Cursor developer to assist

Comments

@soumen02
Copy link

  1. If you can, please include a screenshot of your problem
    Initial error on chat
    image
    When I click Open Settings and index, it got stuck on this for around 5-8 minutes
    image
    After sometime I see the following,
    image
    I continue asking it questions in chat, and when it gives me hallucinated output I go back to the settings page I see the following.
    image
  2. Please include the name of your operating system
    MacOS Sonoma 14.6.1 (23G93)
  3. If you can, steps to reproduce are super helpful
@ascanio
Copy link

ascanio commented Sep 30, 2024

Same Issue here
image
image

@brahyam
Copy link

brahyam commented Sep 30, 2024

Same issue today on similar platform. could this be due to an outage?

@danperks
Copy link
Collaborator

danperks commented Oct 2, 2024

Hi, is this issue still occurring? Seems likely that an outage or temporary bug.

@danperks danperks added bug Something isn't working user-support Regards a specific user's issue with installation or usage labels Oct 2, 2024
@SeekBytes-AI
Copy link

SeekBytes-AI commented Oct 8, 2024

I am having the same issue.
I have reinstalled the cursor after cleanup but did not help.
2024-10-08 19:41:05.109 [info] Handshake timing: 207.13455000007525
2024-10-08 19:41:10.285 [info] Search by sha took 33.64926999993622ms for query ""
2024-10-08 19:41:10.290 [info] Search by message took 39.75151300011203ms for query ""
2024-10-08 19:41:21.111 [info] Handshake start
2024-10-08 19:41:21.318 [info] Handshake timing: 207.79671699996106
2024-10-08 19:41:53.325 [info] Handshake start
2024-10-08 19:41:53.531 [info] Handshake timing: 206.40182100003585
2024-10-08 19:42:04.797 [info] Search by sha took 33.882578999968246ms for query ""
2024-10-08 19:42:04.801 [info] Search by message took 39.56248899991624ms for query ""
2024-10-08 19:42:57.536 [error] Handshake failed:
2024-10-08 19:42:57.536 [error] Error: timeout in handshake with retry
at t.RepoClientMultiplexer.handshakeWithRetry (/Applications/Cursor.app/Contents/Resources/app/extensions/cursor-retrieval/dist/main.js:2:826553)
at async w.getServerStatus (/Applications/Cursor.app/Contents/Resources/app/extensions/cursor-retrieval/dist/main.js:2:841881)
at async w.startIndexingRepository (/Applications/Cursor.app/Contents/Resources/app/extensions/cursor-retrieval/dist/main.js:2:844181)

@daniel-wachira
Copy link

I'm also experiencing this problem. Has anyone managed to find a workaround?

@KekmaTime
Copy link

dude im tired of it happening i tried reinstalling the whole thing but it still persists

@chriswep
Copy link

chriswep commented Oct 8, 2024

@danperks
Copy link
Collaborator

danperks commented Oct 8, 2024

Hey all, devs have been notified and are looking into it - sorry for anyone having issues!

@danperks danperks added dev needed This bug requires a Cursor developer to assist and removed user-support Regards a specific user's issue with installation or usage labels Oct 8, 2024
@danperks danperks changed the title Error Indexing codebase Error Indexing Codebase - Handshake Failed Oct 8, 2024
@athmanar
Copy link

athmanar commented Oct 8, 2024

issue persists:
2024-10-02 10:06:07.652 [info] Setting indexing intent to should-index
2024-10-02 10:06:07.655 [info] Creating merkle client.
2024-10-02 10:06:07.655 [info] Done creating merkle client.
2024-10-02 10:06:07.656 [info] Doing a startup handshake.
2024-10-02 10:06:08.528 [info] Finished initializing merkle tree in 873.6273000240326 ms.
2024-10-02 10:06:08.530 [info] Doing the initial handshake with hash: ba088e651205d23a2561a2a127ba47f54bd00ba8382e36a8877b1168027f860d
2024-10-02 10:06:08.533 [info] Handshake start
2024-10-02 10:06:11.588 [info] Handshake start
2024-10-02 10:06:19.607 [info] Handshake start
2024-10-02 10:06:35.630 [info] Handshake start
2024-10-02 10:07:07.639 [info] Handshake start
2024-10-02 10:08:01.208 [info] Handshake start
2024-10-02 10:09:26.825 [error] Handshake failed:
2024-10-02 10:09:26.827 [error] Error: timeout in handshake with retry
at t.RepoClientMultiplexer.handshakeWithRetry (c:\Users\USER\AppData\Local\Programs\cursor\resources\app\extensions\cursor-retrieval\dist\main.js:2:826553)
at async w.getServerStatus (c:\Users\USER\AppData\Local\Programs\cursor\resources\app\extensions\cursor-retrieval\dist\main.js:2:841881)
at async w.startIndexingRepository (c:\Users\USER\AppData\Local\Programs\cursor\resources\app\extensions\cursor-retrieval\dist\main.js:2:844181)
2024-10-02 10:09:26.829 [error] Handshake failed.
2024-10-02 10:09:26.829 [info] Indexing job successfully done or aborted.

@samgabrail
Copy link

yes same issue here running on windows 11 within WSL2

@henriquebs12
Copy link

Same issue here, it's a pity to see you can't rely on their services. Their reputation just goes down a bit every time theses outages occurs.

@pinion
Copy link

pinion commented Oct 8, 2024

same. mac os x 14.7

Version: 0.41.3
VSCode Version: 1.91.1
Commit: 51c8aff7cb5a89f4a0e462fbacab938bdbfaf140
Date: 2024-09-25T17:13:50.377Z
Electron: 29.4.0
ElectronBuildId: undefined
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.6.0

[info] Repo client: syncing embeddings with backend: https://repo42.cursor.sh
2024-10-08 22:16:41.105 [info] Handshake start
2024-10-08 22:16:57.698 [info] Handshake start
2024-10-08 22:17:30.360 [info] Handshake start
2024-10-08 22:18:35.031 [error] Handshake failed:
2024-10-08 22:18:35.031 [error] Error: timeout in handshake with retry
at t.RepoClientMultiplexer.handshakeWithRetry (/Applications/Cursor.app/Contents/Resources/app/extensions/cursor-retrieval/dist/main.js:2:826553)
at async w.getServerStatus (/Applications/Cursor.app/Contents/Resources/app/extensions/cursor-retrieval/dist/main.js:2:841881)
at async w.startIndexingRepository (/Applications/Cursor.app/Contents/Resources/app/extensions/cursor-retrieval/dist/main.js:2:844181)
2024-10-08 22:18:35.032 [error] Handshake failed.
2024-10-08 22:18:35.032 [info] Indexing job successfully done or aborted.

curl https://repo42.cursor.sh

<title>503 Service Temporarily Unavailable</title>

503 Service Temporarily Unavailable

@georgeliu1998
Copy link

Logging out and back in doesn't solve the issue anymore. Here's my system info:

OS
macOS Sequoia Version 15.0.1 (24A348)

Cursor
Version: 0.41.3
VSCode Version: 1.91.1
Commit: 51c8aff7cb5a89f4a0e462fbacab938bdbfaf140
Date: 2024-09-25T17:13:50.377Z
Electron: 29.4.0
ElectronBuildId: undefined
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 24.0.0

@AtlasPilotPuppy
Copy link

as a developer willing to help fix how can i help / contribute? @danperks

@danperks
Copy link
Collaborator

danperks commented Oct 8, 2024

as a developer willing to help fix how can i help / contribute? @danperks

Hey @AtlasPilotPuppy, thanks for offering to help! Cursor is closed source right now and the dev team are aware of this issue, so for now there's not much that can be done, although I appreciate the offer!

If needed, a dev may ask for more info if they're struggling to reproduce an issue, so keep an eye on this issue and we'll see what happens :)

@cchevall
Copy link

cchevall commented Oct 8, 2024

I just logged out from my cursor account and logged in with a new account. Right after, this issue showed up on all my repositories. Could it be linked?

@afastlearner
Copy link

afastlearner commented Oct 8, 2024

Same Issue here image image

same on windows 11

2024-10-08 23:01:09.418 [info] Setting indexing intent to should-index
2024-10-08 23:01:09.423 [info] Creating merkle client.
2024-10-08 23:01:09.423 [info] Done creating merkle client.
2024-10-08 23:01:09.423 [info] Doing a startup handshake.
2024-10-08 23:01:10.125 [info] Finished initializing merkle tree in 703.151900023222 ms.
2024-10-08 23:01:10.127 [info] Doing the initial handshake with hash: 1647c470a870419358f47f50ce90303cc69542bd420670d32bb8f0972469c45c
2024-10-08 23:01:10.129 [info] Handshake start
2024-10-08 23:01:10.276 [info] Handshake timing: 147.45840001106262
2024-10-08 23:01:12.283 [info] Handshake start
2024-10-08 23:01:12.742 [info] Handshake timing: 460.18099999427795
2024-10-08 23:01:16.754 [info] Handshake start
2024-10-08 23:01:17.307 [info] Handshake timing: 555.0661000013351
2024-10-08 23:01:25.322 [info] Handshake start
2024-10-08 23:01:25.477 [info] Handshake timing: 156.43250000476837
2024-10-08 23:01:41.493 [info] Handshake start
2024-10-08 23:01:41.673 [info] Handshake timing: 181.31760001182556
2024-10-08 23:02:13.676 [info] Handshake start
2024-10-08 23:02:13.974 [info] Handshake timing: 301.04829999804497
2024-10-08 23:03:17.975 [error] Handshake failed:
2024-10-08 23:03:17.976 [error] Error: timeout in handshake with retry
at t.RepoClientMultiplexer.handshakeWithRetry (c:\Users\x\AppData\Local\Programs\cursor\resources\app\extensions\cursor-retrieval\dist\main.js:2:826553)
at async w.getServerStatus (c:\Users\x\AppData\Local\Programs\cursor\resources\app\extensions\cursor-retrieval\dist\main.js:2:841881)
at async w.startIndexingRepository (c:\Users\x\AppData\Local\Programs\cursor\resources\app\extensions\cursor-retrieval\dist\main.js:2:844181)
2024-10-08 23:03:17.976 [error] Handshake failed.
2024-10-08 23:03:17.977 [info] Indexing job successfully done or aborted.

@27Bslash6
Copy link

Same as @c00134744 - would be nice if Cursor's indexing feature respected VSCode proxy configuration so I can bypass system-level proxies and SSL interception.

@hermandr
Copy link

2024-12-17 14:21:06.253 [info] InternalRepoInfo constructor with preferredEmbeddingModel 0
2024-12-17 14:21:06.255 [info] Setting indexing intent to should-index
2024-12-17 14:21:06.259 [info] InternalRepoInfo constructor with preferredEmbeddingModel 0
2024-12-17 14:21:06.266 [info] Creating merkle client.
2024-12-17 14:21:06.266 [info] Done creating merkle client.
2024-12-17 14:21:06.266 [info] Doing a startup handshake.
2024-12-17 14:21:06.400 [info] Finished initializing merkle tree in 78.28407199960202 ms.
2024-12-17 14:21:06.400 [info] Doing the initial handshake with hash: 0db1fda139dab41728b278059d2aff66c609549772d68522a8e93f0d01dfdde6
2024-12-17 14:21:06.403 [info] Handshake start
2024-12-17 14:21:08.026 [error] Error Checking Connection: [unavailable]
2024-12-17 14:21:08.027 [info] Creating Indexing Repo client: https://repo42.cursor.sh
2024-12-17 14:21:09.269 [warning] Retrying handshake with timeout 4000. Error: [unavailable]
2024-12-17 14:21:09.269 [info] Handshake start
2024-12-17 14:21:14.034 [warning] Retrying handshake with timeout 8000. Error: [unavailable]
2024-12-17 14:21:14.034 [info] Handshake start
2024-12-17 14:21:15.568 [error] Error Checking Connection: [unavailable]
2024-12-17 14:21:15.569 [info] Creating Indexing Repo client: https://repo42.cursor.sh
2024-12-17 14:21:22.811 [warning] Retrying handshake with timeout 16000. Error: [unavailable]
2024-12-17 14:21:22.811 [info] Handshake start
2024-12-17 14:21:24.384 [error] Error Checking Connection: [unavailable]
2024-12-17 14:21:24.385 [info] Creating Indexing Repo client: https://repo42.cursor.sh
2024-12-17 14:21:33.021 [info] Search by sha took 29.73665599990636ms for query ""
2024-12-17 14:21:33.038 [info] Search by message took 55.68685000017285ms for query ""
2024-12-17 14:21:39.625 [warning] Retrying handshake with timeout 32000. Error: [unavailable]
2024-12-17 14:21:39.625 [info] Handshake start
2024-12-17 14:21:39.938 [info] Search by message took 37.895245000720024ms for query ""
2024-12-17 14:21:39.944 [info] Search by message took 26.955276999622583ms for query ""
2024-12-17 14:21:39.944 [info] Search by sha took 35.97531499993056ms for query ""
2024-12-17 14:21:39.945 [info] Search by sha took 18.477207999676466ms for query ""
2024-12-17 14:21:41.193 [error] Error Checking Connection: [unavailable]
2024-12-17 14:21:41.194 [info] Creating Indexing Repo client: https://repo42.cursor.sh
2024-12-17 14:22:12.424 [warning] Retrying handshake with timeout 64000. Error: [unavailable]
2024-12-17 14:22:12.424 [info] Handshake start
2024-12-17 14:22:14.064 [error] Error Checking Connection: [unavailable]
2024-12-17 14:22:14.065 [info] Creating Indexing Repo client: https://repo42.cursor.sh
2024-12-17 14:23:17.298 [warning] Retrying handshake with timeout 128000. Error: [unavailable]
2024-12-17 14:23:17.299 [error] Handshake failed:
2024-12-17 14:23:17.299 [error] Error: timeout in handshake with retry
at t.RepoClientMultiplexer.handshakeWithRetry (/home/herman/.cursor-server/bin/a846435528b4b760494a836f96f0739889253530/extensions/cursor-retrieval/dist/main.js:2:813516)
at v.getServerStatus (/home/herman/.cursor-server/bin/a846435528b4b760494a836f96f0739889253530/extensions/cursor-retrieval/dist/main.js:2:830054)
at v.startIndexingRepository (/home/herman/.cursor-server/bin/a846435528b4b760494a836f96f0739889253530/extensions/cursor-retrieval/dist/main.js:2:832745)
2024-12-17 14:23:17.299 [error] Handshake failed.


Version: 0.43.6
VSCode Version: 1.93.1
Commit: a846435528b4b760494a836f96f0739889253530
Date: 2024-12-06T05:11:55.168Z
Electron: 30.5.1
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22635

@jamie0walton
Copy link

jamie0walton commented Dec 26, 2024

This is happening for me on a firewalled debian ssh session using ssh from win 11. In the Debian host I've set the proxy in .bashrc and curl https://repo42.cursor.sh provides a welcome to cursor message. However the shell session that is attempting to access repo421.cursor.sh doesn't appear to be aware of the proxy settings.

Decided to ask cursor to fix cursor. It eventually prompted me to provide the source code :) so after chasing a few rabbit holes I asked it to submit a bug report itself. It's report, based on and interactive session where I tried far too many random command line snippets from what felt like any random version of linux in the past 10 years ...

Worth noting that the host debian box has not internet access, other than via the proxy through ssh tunnelling.

image

@Ma-1003
Copy link

Ma-1003 commented Dec 27, 2024

I'm a Chinese student. When I connect to my school's server via SSH to run programs, it prompts "handshake failed".
image
However, when I open the local project with cursor, indexing works normally.
image
I think it's a server issue, but I don't have the permission to modify the server's DNS. Do you have any suggestions or ideas to solve this problem? Thank you! :) I use Windows 10.

@danperks danperks unpinned this issue Jan 15, 2025
@DylanDelobel
Copy link

Same issue

2025-01-21 13:24:38.439 [info] Doing the initial handshake with hash: 2d691cf65f011dcfde65fe36c79e1305e63ae64e4c66e9d55cac1eca08bc48e5
2025-01-21 13:24:38.440 [info] Handshake start
2025-01-21 13:24:38.780 [info] Handshake timing: 340.4893000000002
2025-01-21 13:24:40.793 [warning] Retrying handshake with timeout 4000. Error:  FastRepoInitHandshakeResponse_Status.FAILURE in handshakeWithRetry
2025-01-21 13:24:40.793 [info] Handshake start
2025-01-21 13:24:40.918 [info] Handshake timing: 126.48109999999997
2025-01-21 13:24:44.929 [warning] Retrying handshake with timeout 8000. Error:  FastRepoInitHandshakeResponse_Status.FAILURE in handshakeWithRetry
2025-01-21 13:24:44.929 [info] Handshake start
2025-01-21 13:24:45.052 [info] Handshake timing: 123.89649999999892
2025-01-21 13:24:53.055 [warning] Retrying handshake with timeout 16000. Error:  FastRepoInitHandshakeResponse_Status.FAILURE in handshakeWithRetry
2025-01-21 13:24:53.056 [info] Handshake start
2025-01-21 13:24:53.175 [info] Handshake timing: 120.29859999999826
2025-01-21 13:25:09.183 [warning] Retrying handshake with timeout 32000. Error:  FastRepoInitHandshakeResponse_Status.FAILURE in handshakeWithRetry
2025-01-21 13:25:09.183 [info] Handshake start
2025-01-21 13:25:09.306 [info] Handshake timing: 123.41860000000452
2025-01-21 13:25:41.316 [warning] Retrying handshake with timeout 64000. Error:  FastRepoInitHandshakeResponse_Status.FAILURE in handshakeWithRetry
2025-01-21 13:25:41.316 [info] Handshake start
2025-01-21 13:25:41.432 [info] Handshake timing: 117.06819999999425

@raulgad
Copy link

raulgad commented Jan 21, 2025

Same issue. MacOS Sequoia 15.2

Version: 0.44.11
VSCode Version: 1.93.1
Commit: fe574d0820377383143b2ea26aa6ae28b3425220
Date: 2025-01-03T07:59:06.361Z (2 wks ago)
Electron: 30.5.1
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.2.0

@yusufsiregar44
Copy link

The same issue is happening now. My OS is MacOS Sequoia 15.2.

Version: 0.44.11
VSCode Version: 1.93.1
Commit: fe574d0820377383143b2ea26aa6ae28b3425220
Date: 2025-01-03T07:59:06.361Z (2 wks ago)
Electron: 30.5.1
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.2.0

Image

@ostwalprasad
Copy link

Same issue. Lot of people got this issue today.

@smaga38
Copy link

smaga38 commented Jan 21, 2025

The same issue is happening now. Windows 11
Version: 0.44.11
VSCode Version: 1.93.1
Commit: fe574d0820377383143b2ea26aa6ae28b3425220
Date: 2025-01-03T07:59:06.361Z
Electron: 30.5.1
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631

@chaosIV
Copy link

chaosIV commented Jan 21, 2025

help 😭😭😭😭😭😭
版本: 0.44.11
提交: 1.93.1
日期: fe574d0820377383143b2ea26aa6ae28b3425220
Electron: 2025-01-03T07:59:06.361Z
ElectronBuildId: 30.5.1
Chromium: undefined
Node.js: 124.0.6367.243
V8: 20.16.0
OS: 12.4.254.20-electron.0

@yusufsiregar44
Copy link

@danperks Can we pin this issue again for everyone's visibility? It appears to be affecting many people.

@danperks
Copy link
Collaborator

danperks commented Jan 21, 2025

Hey, thanks for the reports guys. More info tracking this can be found here: https://status.cursor.com/

This is not a bug on our end, and will resolve as soon as OpenAI resolve the degradation on their end

@danperks danperks pinned this issue Jan 21, 2025
@danperks danperks marked this as a duplicate of #2608 Jan 21, 2025
@DevGuyRash
Copy link

DevGuyRash commented Jan 22, 2025

I'm trying to use cursor and am experiencing this issue right now. Have tried re-signing in as well. Handshake fails every time.

Image

@sk-tjdownes
Copy link

Same

Version: 0.45.0
VSCode Version: 1.96.2
Commit: f06cc5e62b757b2bf61ec052a8701fb2da9ded20
Date: 2025-01-20T19:17:28.428Z
Electron: 32.2.6
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26100

Image

@amojury
Copy link

amojury commented Jan 22, 2025

same

@CN-CJ
Copy link

CN-CJ commented Jan 22, 2025

same

版本: 0.44.11
提交: 1.93.1
日期: fe574d0820377383143b2ea26aa6ae28b3425220
Electron: 2025-01-03T07:59:06.361Z
ElectronBuildId: 30.5.1
Chromium: undefined
Node.js: 124.0.6367.243
V8: 20.16.0
OS: 12.4.254.20-electron.0

@rshabhsinha
Copy link

facing this exact same issue

@serend1p1ty
Copy link

Same issue here.

Image

Image

@bgbg
Copy link

bgbg commented Jan 30, 2025

Related to this https://forum.cursor.com/t/cursor-cannot-create-index-behind-corporate-proxy/31317

I too, experience this problem when working on an SSH project that requires me to use corporate VPN

@danielkubat
Copy link

Related to this https://forum.cursor.com/t/cursor-cannot-create-index-behind-corporate-proxy/31317

I too, experience this problem when working on an SSH project that requires me to use corporate VPN

did you try to disable http2? for me, it fixed the issue.

"cursor.general.disableHttp2": true,

@jamie0walton
Copy link

Related to this https://forum.cursor.com/t/cursor-cannot-create-index-behind-corporate-proxy/31317
I too, experience this problem when working on an SSH project that requires me to use corporate VPN

did you try to disable http2? for me, it fixed the issue.

"cursor.general.disableHttp2": true,

OK, I do NOT have an issue with a corporate proxy however this setting clearly changes something about the way the indexing works as indexing code through an SSH connection works with this change for me.

Thanks!

@tblatrille
Copy link

Related to this https://forum.cursor.com/t/cursor-cannot-create-index-behind-corporate-proxy/31317
I too, experience this problem when working on an SSH project that requires me to use corporate VPN

did you try to disable http2? for me, it fixed the issue.

"cursor.general.disableHttp2": true,

This fixed it for me. thanks

@zachsa999
Copy link

esp-idf broke codebase indexing for me. I uninstalled that plugin and it worked perfectly.

@MattMorgis
Copy link

I had the same issue in a dev container on macOS host with corporate firewall. I was able to curl and make requests from the container through the firewall just fine, but always got handshake failed with indexing.

"cursor.general.disableHttp2": true in my project settings did the trick as well

@BadaLeexxx
Copy link

I connected to remote server A, codebase not indexed. The cursor version is 0.44.11. I tried uninstalling and reinstalling, logging out and back in, and disabling http2. The problem is still the same. However, when I connected to remote server B, this function worked. What should I do?

Image

Image

Image

@maxlk96
Copy link

maxlk96 commented Feb 13, 2025

Having the same issue..

Version: 0.45.11
VSCode Version: 1.96.2
Commit: f5f18731406b73244e0558ee7716d77c8096d150
Date: 2025-02-07T09:43:58.555Z
Electron: 32.2.6
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev needed This bug requires a Cursor developer to assist
Projects
None yet
Development

No branches or pull requests