-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vendor-option graphic-margin #971
feat: add vendor-option graphic-margin #971
Conversation
2fd05bc
to
94b1167
Compare
Basically it looks good. Maybe it is smarter to have the vendorOptions deactivated by default.
Adding them to the
Best way would probably to add an additional option just for |
94b1167
to
e9555ad
Compare
e9555ad
to
19e53d0
Compare
19e53d0
to
3429c06
Compare
Thanks for the answers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks
Thanks for the review @KaiVolland (I' can 't merge by myself) |
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
For #969
I add here a first
VendorOption
with thegraphic-margin
property. This is linked to theadditional Geostyler-styler
GraphicFillPadding
property: geostyler/geostyler-style#651As It's the first VendorOption, I've several questions:
src/SldStyleParser.geoserver.spec.ts
? Or should I had a dedicated test file ?withVendorOption
parameter into the Geostyler demo, cli or qgis plugin ? Should I create and issue about that ("be more flexible with parser options") ?