Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading CDATA values from SLD #948

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix reading CDATA values from SLD #948

merged 3 commits into from
Jul 9, 2024

Conversation

KaiVolland
Copy link
Contributor

This fixes parsing of <![CDATA[xxx]]> values.

It removes the configured cdataPropName from the parser.

Closes #947

@louwers i used your linked SLD for this test. If you don't want it to be in the repo just let me know and i will break it down to a simpler example and use this instead.

@louwers
Copy link

louwers commented Jul 8, 2024

It is from the Dutch gov’t and is in the public domain as far as I am aware. Feel free to use it.

@marcjansen
Copy link
Contributor

A short note next to the dataset with an URL and a statement that it is pd doesn't hurt though and might make future reviews easier.

@KaiVolland KaiVolland merged commit 3afb066 into main Jul 9, 2024
7 checks passed
@KaiVolland KaiVolland deleted the fix-reading-cdata branch July 9, 2024 10:53
@jansule
Copy link
Contributor

jansule commented Jul 9, 2024

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<![CDATA[xxx]]> not handled correctly
5 participants