Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoServer <sld:VendorOptions name="graphic-margin" /> handling is unstable #987

Closed
sebastianfrey opened this issue Feb 21, 2025 · 0 comments · Fixed by #988
Closed

GeoServer <sld:VendorOptions name="graphic-margin" /> handling is unstable #987

sebastianfrey opened this issue Feb 21, 2025 · 0 comments · Fixed by #988
Assignees
Labels
bug Something isn't working

Comments

@sebastianfrey
Copy link
Contributor

Bug

Describe the bug
The in #971 introduced support for GeoServer <sld:VendorOptions name="graphic-margin" /> tags, does not handle all supported format definitions of the graphic-margin property.

Currently the parser expects multiple margins to be separated by comma. As stated in this GeoServer guide, multiple margins can be separated by space.

To Reproduce
Steps to reproduce the behavior:
1.Use https://github.com/geostyler/geostyler-sld-parser/blob/main/data/slds/geoserver/pattern_polygon.sld

  1. Change all commas for <sld:VendorOptions name="graphic-margin" /> to spaces
  2. Symbolizer#graphicFillPadding is an array of NaN.

Expected behavior
<sld:VendorOptions name="graphic-margin" /> tags with multiple margins separated by space should be supported.

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

If desired I am happy, to provide a PR to fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants