fix: support only spaces as separator in vendor-option graphic-margin

geostyler · Feb 25, 2025 · b01783d · b01783d
1 parent 4c36a74
commit b01783d
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 45 deletions.
diff --git a/data/slds/geoserver/pattern_polygon.sld b/data/slds/geoserver/pattern_polygon.sld
@@ -15,7 +15,7 @@
           <Name>Polygon with spaced purple circle symbols</Name>
           <Abstract>Polygon with spaced purple circle symbols</Abstract>
           <PolygonSymbolizer>
-            <VendorOption name="graphic-margin">4,6,2,3</VendorOption>
+            <VendorOption name="graphic-margin">4 6 2 3</VendorOption>
             <Fill>
               <GraphicFill>
                 <Graphic>

diff --git a/data/slds/geoserver/pattern_polygon_alternative_margin.sld b/data/slds/geoserver/pattern_polygon_alternative_margin.sld
diff --git a/src/SldStyleParser.geoserver.spec.ts b/src/SldStyleParser.geoserver.spec.ts
@@ -185,12 +185,6 @@ describe('SldStyleParser implements StyleParser', () => {
       expect(geoStylerStyle).toBeDefined();
       expect(geoStylerStyle).toEqual(pattern_polygon);
     });
-    it('can read the geoserver pattern_polygon_alternative_margin.sld', async () => {
-      const sld = fs.readFileSync('./data/slds/geoserver/pattern_polygon_alternative_margin.sld', 'utf8');
-      const { output: geoStylerStyle } = await styleParser.readStyle(sld);
-      expect(geoStylerStyle).toBeDefined();
-      expect(geoStylerStyle).toEqual(pattern_polygon);
-    });
   });
 
   describe('#writeStyle', () => {

diff --git a/src/SldStyleParser.ts b/src/SldStyleParser.ts
@@ -1001,7 +1001,7 @@ export class SldStyleParser implements StyleParser<string> {
     if (this.withGeoServerVendorOption) {
       const graphicFillPadding = getVendorOptionValue(sldSymbolizer, 'graphic-margin');
       if (!isNil(graphicFillPadding)) {
-        fillSymbolizer.graphicFillPadding = graphicFillPadding.split(/[,\s]/).map(numberExpression);
+        fillSymbolizer.graphicFillPadding = graphicFillPadding.split(/\s/).map(numberExpression);
       }
     }
     if (!isNil(color)) {