Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge of hashes #54

Closed
jceaser opened this issue Dec 6, 2024 · 1 comment · Fixed by #55
Closed

edge of hashes #54

jceaser opened this issue Dec 6, 2024 · 1 comment · Fixed by #55

Comments

@jceaser
Copy link

jceaser commented Dec 6, 2024

Can you add a test for latitude 0.0 and longitude -180.0 and other such edges? You return 80000, which I think is correct but is not what tools like https://www.geohash.es/encode or https://github.com/wdm0006/pygeohash return. They return 2pbpbpb which looks like a rounding error. Since you have a spread sheet for these tests, I think you should add the official results for these locations. At least then I know where you officially stand on this issue.

@sunng87
Copy link
Member

sunng87 commented Dec 14, 2024

@jceaser I just added this case in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants