Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent pubs growth value of -100% #458

Open
za158 opened this issue Jun 25, 2024 · 6 comments
Open

Recent pubs growth value of -100% #458

za158 opened this issue Jun 25, 2024 · 6 comments

Comments

@za158
Copy link
Member

za158 commented Jun 25, 2024

image

@za158
Copy link
Member Author

za158 commented Jun 25, 2024

The issue being: how can the average change be -100% for more than one year? Or are years with 0 change getting dropped?

@jmelot
Copy link
Member

jmelot commented Jun 26, 2024

Years with 0 in the denominator of the pct change calculation are getting dropped. These cases seem to crop up when the org does very sporadic publishing, a paper or patent every now and then. I agree this might be confusing... maybe we should update the metric or just not display the percentage change for these orgs.

@za158
Copy link
Member Author

za158 commented Jun 26, 2024

How about we display "n/a" with a tooltip indicating "Insufficient data to calculate"? @brianlove

@brianlove
Copy link
Contributor

@za158 This "N/A"+tooltip is for any growth column with a total of -100?

@jmelot
Copy link
Member

jmelot commented Jun 26, 2024

Yeah I'm not sure we should do this for any such column. We could instead update the preprocessing code so that in cases where any of the pct changes would have a 0 in the denominator, we return null, triggering the existing N/A on the front end

@za158
Copy link
Member Author

za158 commented Jun 26, 2024

Seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants